Push API: Implement and ship PushSubscription.options

third_party/WebKit/Source/modules/push_messaging/PushSubscription.h

Index: third_party/WebKit/Source/modules/push_messaging/PushSubscription.h
diff --git a/third_party/WebKit/Source/modules/push_messaging/PushSubscription.h b/third_party/WebKit/Source/modules/push_messaging/PushSubscription.h
index e21dcbd17cab48ac626c0f0c10b1501dfc8f2965..a50f1e3744bceedd1780e680cd3141673eb649ae 100644
--- a/third_party/WebKit/Source/modules/push_messaging/PushSubscription.h
+++ b/third_party/WebKit/Source/modules/push_messaging/PushSubscription.h
@@ -17,6 +17,7 @@
 
 namespace blink {
 
+class PushSubscriptionOptions;
 class ServiceWorkerRegistration;
 class ScriptPromiseResolver;
 class ScriptState;
@@ -30,7 +31,9 @@ public:
 
     virtual ~PushSubscription();
 
-    KURL endpoint() const;
+    KURL endpoint() const { return m_endpoint; }
+
+    PushSubscriptionOptions* options() const { return m_options; }

[Peter Beverloo, 2016/07/08 18:30:12]

nit: looking throughout the code, it's *much* more common to return
m_options.get() than it is to rely on the conversion operator.

[johnme, 2016/07/13 17:51:57]

Done.

 
     DOMArrayBuffer* getKey(const AtomicString& name) const;
     ScriptPromise unsubscribe(ScriptState*);
@@ -44,6 +47,8 @@ private:
 
     KURL m_endpoint;
 
+    Member<PushSubscriptionOptions> m_options;
+
     Member<DOMArrayBuffer> m_p256dh;
     Member<DOMArrayBuffer> m_auth;