content/renderer/push_messaging/push_messaging_dispatcher.h - Issue 2133673002: Push API: Implement and ship PushSubscription.options

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/push_messaging/push_messaging_dispatcher.h

Issue 2133673002: Push API: Implement and ship PushSubscription.options (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/child/push_messaging/push_provider.cc ('K') | « content/common/push_messaging_messages.h ('k') | content/renderer/push_messaging/push_messaging_dispatcher.cc » ('j') | third_party/WebKit/LayoutTests/http/tests/push_messaging/push-subscription-options.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/push_messaging/push_messaging_dispatcher.h

diff --git a/content/renderer/push_messaging/push_messaging_dispatcher.h b/content/renderer/push_messaging/push_messaging_dispatcher.h

index 5fb894f6b5c91ef9cd9dd0d79f967a50c9c33e00..9574c117aa10504b98da44e369f3508f79506d4c 100644

--- a/content/renderer/push_messaging/push_messaging_dispatcher.h

+++ b/content/renderer/push_messaging/push_messaging_dispatcher.h

@@ -63,6 +63,7 @@ class PushMessagingDispatcher : public RenderFrameObserver,

void OnSubscribeFromDocumentSuccess(int32_t request_id,

const GURL& endpoint,

+ const PushSubscriptionOptions& options,

const std::vector<uint8_t>& p256dh,

const std::vector<uint8_t>& auth);