content/common/push_messaging_messages.h - Issue 2133673002: Push API: Implement and ship PushSubscription.options

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/push_messaging_messages.h

Issue 2133673002: Push API: Implement and ship PushSubscription.options (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/child/push_messaging/push_provider.cc ('K') | « content/child/push_messaging/push_provider.cc ('k') | content/renderer/push_messaging/push_messaging_dispatcher.h » ('j') | third_party/WebKit/LayoutTests/http/tests/push_messaging/push-subscription-options.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/push_messaging_messages.h

diff --git a/content/common/push_messaging_messages.h b/content/common/push_messaging_messages.h

index f3710684a3d82fb1d79f524058293f8b8e8a6f47..5e1caf421a6e8ad36a265249f3e633e46a7cc5ba 100644

--- a/content/common/push_messaging_messages.h

+++ b/content/common/push_messaging_messages.h

@@ -37,15 +37,17 @@ IPC_STRUCT_TRAITS_END()

// Messages sent from the browser to the child process.

-IPC_MESSAGE_ROUTED4(PushMessagingMsg_SubscribeFromDocumentSuccess,

+IPC_MESSAGE_ROUTED5(PushMessagingMsg_SubscribeFromDocumentSuccess,

int32_t /* request_id */,

GURL /* push_endpoint */,

+ content::PushSubscriptionOptions /* options */,

std::vector<uint8_t> /* p256dh */,

std::vector<uint8_t> /* auth */)

-IPC_MESSAGE_CONTROL4(PushMessagingMsg_SubscribeFromWorkerSuccess,

+IPC_MESSAGE_CONTROL5(PushMessagingMsg_SubscribeFromWorkerSuccess,

int32_t /* request_id */,

GURL /* push_endpoint */,

+ content::PushSubscriptionOptions /* options */,

std::vector<uint8_t> /* p256dh */,

std::vector<uint8_t> /* auth */)

@@ -66,9 +68,10 @@ IPC_MESSAGE_CONTROL3(PushMessagingMsg_UnsubscribeError,

blink::WebPushError::ErrorType /* error_type */,

std::string /* error_message */)

-IPC_MESSAGE_CONTROL4(PushMessagingMsg_GetSubscriptionSuccess,

+IPC_MESSAGE_CONTROL5(PushMessagingMsg_GetSubscriptionSuccess,

int32_t /* request_id */,

GURL /* push_endpoint */,

+ content::PushSubscriptionOptions /* options */,

std::vector<uint8_t> /* p256dh */,

std::vector<uint8_t> /* auth */)