Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 21279005: Tweak -mssse3 on Mac a little. (Closed)

Created:
7 years, 4 months ago by mtklein
Modified:
7 years, 4 months ago
Reviewers:
bungeman-skia, epoger
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Tweak -mssse3 on Mac a little. Using OTHER_CPLUSPLUSFLAGS instead of OTHER_CFLAGS will append -mssse3 into the argument list instead of overwriting as the old note warns about. (So it's actually there twice now for the files in opts_ssse3, and we can still build if we remove -mssse3 from common_conditions.gypi.) We could also just delete this clause entirely given that common_conditions.gypi sets it anyway. Which do you think is best? This code won't compile unless _someone_ has set -mssse3. Seems to me the redundancy helps communicate that and protect against changes in common_conditions.gypi. BUG= Committed: http://code.google.com/p/skia/source/detail?r=10573

Patch Set 1 #

Total comments: 1

Patch Set 2 : just delete it #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -8 lines) Patch
M gyp/opts.gyp View 1 1 chunk +1 line, -8 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
mtklein
7 years, 4 months ago (2013-07-31 15:58:33 UTC) #1
epoger
Sorry for the late response... https://codereview.chromium.org/21279005/diff/1/gyp/opts.gyp File gyp/opts.gyp (right): https://codereview.chromium.org/21279005/diff/1/gyp/opts.gyp#newcode130 gyp/opts.gyp:130: 'OTHER_CPLUSPLUSFLAGS': ['-mssse3',], I don't ...
7 years, 4 months ago (2013-08-06 15:38:32 UTC) #2
mtklein
On 2013/08/06 15:38:32, epoger wrote: > Sorry for the late response... > > https://codereview.chromium.org/21279005/diff/1/gyp/opts.gyp > ...
7 years, 4 months ago (2013-08-06 15:50:39 UTC) #3
epoger
lgtm
7 years, 4 months ago (2013-08-06 15:51:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@google.com/21279005/5001
7 years, 4 months ago (2013-08-06 15:56:51 UTC) #5
commit-bot: I haz the power
7 years, 4 months ago (2013-08-06 18:13:04 UTC) #6
Message was sent while issue was closed.
Change committed as 10573

Powered by Google App Engine
This is Rietveld 408576698