Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Unified Diff: gyp/opts.gyp

Issue 21279005: Tweak -mssse3 on Mac a little. (Closed) Base URL: https://skia.googlecode.com/svn/trunk
Patch Set: just delete it Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gyp/opts.gyp
diff --git a/gyp/opts.gyp b/gyp/opts.gyp
index 12c4dc560c18b1eac8ce768dcf823499b8a9a202..8a48b9ad2a17f8a2167e900a3b4d7764221ba74b 100644
--- a/gyp/opts.gyp
+++ b/gyp/opts.gyp
@@ -122,14 +122,7 @@
'-mssse3',
],
}],
- # TODO(epoger): the following will enable SSSE3 on Macs, but it will
- # break once we set OTHER_CFLAGS anywhere else (the first setting will
- # be replaced, not added to)
- [ 'skia_os in ["mac"]', {
- 'xcode_settings': {
- 'OTHER_CFLAGS': ['-mssse3',],
- },
- }],
+ # (Mac has -mssse3 globally.)
[ 'skia_arch_type == "x86"', {
'sources': [
'../src/opts/SkBitmapProcState_opts_SSSE3.cpp',
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698