chrome/renderer/pepper/pepper_uma_host.cc - Issue 2127373006: Use base::StartWith() in more places when appropriate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/pepper/pepper_uma_host.cc

Issue 2127373006: Use base::StartWith() in more places when appropriate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix build, fix error Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/importer/firefox_importer_utils.cc ('k') | chrome/test/chromedriver/chrome/browser_info.cc » ('j') | components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/pepper/pepper_uma_host.cc

diff --git a/chrome/renderer/pepper/pepper_uma_host.cc b/chrome/renderer/pepper/pepper_uma_host.cc

index 6a1e5a32dbbf8c6dfa57877b2ff99066a483ceab..56ef732c6648c20bb7363e113b3b2c360281cea8 100644

--- a/chrome/renderer/pepper/pepper_uma_host.cc

+++ b/chrome/renderer/pepper/pepper_uma_host.cc

@@ -10,6 +10,7 @@

#include "base/metrics/histogram.h"

#include "base/sha1.h"

#include "base/strings/string_number_conversions.h"

+#include "base/strings/string_util.h"

#include "chrome/common/chrome_content_client.h"

#include "chrome/common/chrome_switches.h"

#include "chrome/common/render_messages.h"

@@ -113,7 +114,8 @@ bool PepperUMAHost::IsPluginWhitelisted() {

}

bool PepperUMAHost::IsHistogramAllowed(const std::string& histogram) {

- if (is_plugin_in_process_ && histogram.find("NaCl.") == 0) {

+ if (is_plugin_in_process_ &&

+ base::StartsWith(histogram, "NaCl.", base::CompareCase::SENSITIVE)) {

return true;

}