chrome/common/importer/firefox_importer_utils.cc - Issue 2127373006: Use base::StartWith() in more places when appropriate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/importer/firefox_importer_utils.cc

Issue 2127373006: Use base::StartWith() in more places when appropriate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix build, fix error Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/startup/startup_browser_creator.cc ('k') | chrome/renderer/pepper/pepper_uma_host.cc » ('j') | components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/importer/firefox_importer_utils.cc

diff --git a/chrome/common/importer/firefox_importer_utils.cc b/chrome/common/importer/firefox_importer_utils.cc

index 76a76a2c5e3de9da00d3a0370979dd6eb8a45008..e1f5ada77718755f5a59d78e63a14e500330e002 100644

--- a/chrome/common/importer/firefox_importer_utils.cc

+++ b/chrome/common/importer/firefox_importer_utils.cc

@@ -311,10 +311,11 @@ base::string16 GetFirefoxImporterName(const base::FilePath& app_path) {

if (line == "[App]") {

in_app_section = true;

} else if (in_app_section) {

- if (line.find(name_attr) == 0) {

+ if (base::StartsWith(line, name_attr, base::CompareCase::SENSITIVE)) {

line.substr(name_attr.size()).CopyToString(&branding_name);

break;

- } else if (line.length() > 0 && line[0] == '[') {

+ }

+ if (line.length() > 0 && line[0] == '[') {

// No longer in the [App] section.

break;

}