Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 21265003: Rename DiagnosticEvent to GoogleNowEvent (Closed)

Created:
7 years, 4 months ago by robliao
Modified:
7 years, 4 months ago
Reviewers:
xiyuan, vadimt, Mark P
CC:
chromium-reviews, Ilya Sherman, arv+watch_chromium.org, asvitkine+watch_chromium.org, jar (doing other things)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Rename DiagnosticEvent to GoogleNowEvent DiagnosticEvent wasn't really a diagnostic event. It's a UMA event to track the flow of Google Now. GoogleNowEvent captures this and aligns with the name in histograms.xml BUG=164227 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=214773

Patch Set 1 #

Patch Set 2 : Rebasing to the State Machine Change #

Total comments: 2

Patch Set 3 : Quick Feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -21 lines) Patch
M chrome/browser/resources/google_now/background.js View 1 10 chunks +15 lines, -15 lines 0 comments Download
M chrome/browser/resources/google_now/background_unittest.gtestjs View 1 5 chunks +5 lines, -5 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
robliao
7 years, 4 months ago (2013-07-30 18:38:08 UTC) #1
vadimt
lgtm
7 years, 4 months ago (2013-07-30 18:39:45 UTC) #2
robliao
Rebasing to the State Machine Change
7 years, 4 months ago (2013-07-30 18:44:34 UTC) #3
robliao
Owners: Please provide owner approval for the files listed under your name. Thanks! xiyuan: chrome/browser/resources/google_now/background.js ...
7 years, 4 months ago (2013-07-30 18:59:54 UTC) #4
Mark P
https://codereview.chromium.org/21265003/diff/5001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/21265003/diff/5001/tools/metrics/histograms/histograms.xml#newcode17607 tools/metrics/histograms/histograms.xml:17607: Events in Google Now component extension. See var GoogleNowEvent. ...
7 years, 4 months ago (2013-07-30 19:07:54 UTC) #5
xiyuan
lgtm
7 years, 4 months ago (2013-07-30 19:47:10 UTC) #6
robliao
https://codereview.chromium.org/21265003/diff/5001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/21265003/diff/5001/tools/metrics/histograms/histograms.xml#newcode17607 tools/metrics/histograms/histograms.xml:17607: Events in Google Now component extension. See var GoogleNowEvent. ...
7 years, 4 months ago (2013-07-30 19:53:49 UTC) #7
Mark P
lgtm
7 years, 4 months ago (2013-07-31 15:04:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robliao@chromium.org/21265003/13001
7 years, 4 months ago (2013-07-31 15:06:11 UTC) #9
commit-bot: I haz the power
7 years, 4 months ago (2013-07-31 17:50:37 UTC) #10
Message was sent while issue was closed.
Change committed as 214773

Powered by Google App Engine
This is Rietveld 408576698