Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 21204002: core/svg: Include wtf files using "wtf/foo.h" form. (Closed)

Created:
7 years, 4 months ago by tfarina
Modified:
7 years, 4 months ago
Reviewers:
pdr., Nico, abarth-chromium
CC:
blink-reviews, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), eae+blinkwatch, Timothy Loh, dstockwell, dglazkov+blink, f(malita), darktears, pdr, Stephen Chennney, Steve Block, Eric Willigers
Visibility:
Public.

Description

core/svg: Include wtf files using "wtf/foo.h" form. Instead of including them as: \#include <wtf/foo.h> Change it to include as: \#include "wtf/foo.h" Patch generated with thakis's script: git grep -l '#include <wtf' Source/core/svg | xargs sed -i -e 's/#include <\(wtf\/[^>]*\)>/#include "\1"/' BUG=254653 R=abarth@chromium.org,thakis@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155145

Patch Set 1 #

Patch Set 2 : fixes #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -141 lines) Patch
M Source/core/svg/ColorDistance.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/svg/SVGAltGlyphDefElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGAltGlyphElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGAltGlyphItemElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGAngle.cpp View 1 1 chunk +2 lines, -3 lines 0 comments Download
M Source/core/svg/SVGAnimateElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGAnimateMotionElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGAnimatedInteger.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/svg/SVGAnimatedTypeAnimator.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGAnimationElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGColor.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGDocumentExtensions.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/svg/SVGDocumentExtensions.cpp View 1 2 chunks +1 line, -2 lines 0 comments Download
M Source/core/svg/SVGElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGElementInstance.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGElementRareData.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGExternalResourcesRequired.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFilterPrimitiveStandardAttributes.h View 1 1 chunk +2 lines, -3 lines 0 comments Download
M Source/core/svg/SVGFitToViewBox.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFitToViewBox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFontData.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGForeignObjectElement.cpp View 1 2 chunks +1 line, -2 lines 0 comments Download
M Source/core/svg/SVGGlyphRefElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGLangSpace.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGLangSpace.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/svg/SVGLengthList.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGLengthList.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/svg/SVGNumberList.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGNumberList.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/svg/SVGPaint.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGParserUtilities.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPathBlender.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/svg/SVGPathByteStream.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGPathByteStreamBuilder.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGPathByteStreamSource.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPathConsumer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGPathParser.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGPathParser.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/svg/SVGPathSegList.h View 1 chunk +2 lines, -3 lines 0 comments Download
M Source/core/svg/SVGPathSegListSource.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGPathStringBuilder.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPathStringBuilder.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGPathStringSource.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGPathUtilities.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGPointList.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPointList.cpp View 1 1 chunk +2 lines, -3 lines 0 comments Download
M Source/core/svg/SVGPreserveAspectRatio.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/svg/SVGRect.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGRenderingIntent.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/svg/SVGSVGElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGStringList.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGStringList.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/svg/SVGStyleElement.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/svg/SVGStyledElement.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGStyledElement.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/svg/SVGTransform.cpp View 1 1 chunk +3 lines, -4 lines 0 comments Download
M Source/core/svg/SVGTransformList.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGTransformList.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/svg/SVGTransformable.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGUnitTypes.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGZoomAndPan.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/animation/SMILTime.h View 1 chunk +1 line, -1 line 3 comments Download
M Source/core/svg/animation/SMILTimeContainer.h View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/core/svg/animation/SMILTimeContainer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/animation/SVGSMILElement.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/svg/animation/SVGSMILElement.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/svg/graphics/SVGImageCache.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/svg/graphics/filters/SVGFilter.h View 1 1 chunk +3 lines, -4 lines 0 comments Download
M Source/core/svg/graphics/filters/SVGFilterBuilder.h View 1 1 chunk +5 lines, -6 lines 0 comments Download
M Source/core/svg/graphics/filters/SVGFilterBuilder.cpp View 1 1 chunk +2 lines, -3 lines 0 comments Download
M Source/core/svg/properties/SVGAnimatedProperty.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/properties/SVGAnimatedPropertyMacros.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/properties/SVGProperty.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/properties/SVGPropertyInfo.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/properties/SVGPropertyTraits.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
tfarina
7 years, 4 months ago (2013-07-30 03:12:42 UTC) #1
pdr.
LGTM https://codereview.chromium.org/21204002/diff/3001/Source/core/svg/animation/SMILTime.h File Source/core/svg/animation/SMILTime.h (right): https://codereview.chromium.org/21204002/diff/3001/Source/core/svg/animation/SMILTime.h#newcode29 Source/core/svg/animation/SMILTime.h:29: #include <algorithm> Is this in the correct order ...
7 years, 4 months ago (2013-07-30 03:16:23 UTC) #2
tfarina
https://codereview.chromium.org/21204002/diff/3001/Source/core/svg/animation/SMILTime.h File Source/core/svg/animation/SMILTime.h (right): https://codereview.chromium.org/21204002/diff/3001/Source/core/svg/animation/SMILTime.h#newcode29 Source/core/svg/animation/SMILTime.h:29: #include <algorithm> On 2013/07/30 03:16:23, pdr wrote: > Is ...
7 years, 4 months ago (2013-07-30 03:18:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/21204002/3001
7 years, 4 months ago (2013-07-30 03:21:16 UTC) #4
commit-bot: I haz the power
Change committed as 155145
7 years, 4 months ago (2013-07-30 07:49:22 UTC) #5
Nico
7 years, 4 months ago (2013-07-30 15:19:21 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/21204002/diff/3001/Source/core/svg/animation/...
File Source/core/svg/animation/SMILTime.h (right):

https://codereview.chromium.org/21204002/diff/3001/Source/core/svg/animation/...
Source/core/svg/animation/SMILTime.h:29: #include <algorithm>
On 2013/07/30 03:18:59, tfarina wrote:
> On 2013/07/30 03:16:23, pdr wrote:
> > Is this in the correct order now?
> no, but I left it intentionally :(
> 
> I wish we could change Blink to follow Chromium order here:

For now, blink does not follow chromium order.

> 
> foo.h
> 
> c includes
> c++ includes
> 
> project includes.

Powered by Google App Engine
This is Rietveld 408576698