Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(710)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2119263002: [DO NOT LAND: Dummy CL] Storage of ComputedStyle separate from LayoutObject. (Closed)

Created:
4 years, 5 months ago by nainar
Modified:
4 years, 2 months ago
Reviewers:
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DO NOT LAND: Dummy CL] Storage of ComputedStyle separate from LayoutObject. Part of stage 1 in separation of style resolution and layout tree construction Design doc: bit.ly/24nQ9UQ Changes the Node::m_data DataUnion to now allow a ComputedStyle. Updates Node flags with new flag HasLayoutObject to indicate whether the DataUnion is a LayoutObject or a ComputedStyle. Adds new hasLayoutObject method to check flag. Updates ComputedStyle and Layoutobject getters and setters accordingly. Written with nainar@ BUG=595137 patch from issue 1962953002 at patchset 260001 (http://crrev.com/1962953002#ps260001)

Patch Set 1 #

Patch Set 2 : Dummy CL #

Patch Set 3 : Storage of ComputedStyle separate from LayoutObject. #

Patch Set 4 : Storage of ComputedStyle separate from LayoutObject. #

Patch Set 5 : rebase #

Patch Set 6 : rebase #

Patch Set 7 : rebase #

Patch Set 8 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -37 lines) Patch
M third_party/WebKit/Source/core/dom/Element.h View 1 2 3 4 5 6 7 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Node.h View 1 2 3 4 5 6 5 chunks +42 lines, -30 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Node.cpp View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/NodeComputedStyle.h View 1 2 3 4 2 chunks +10 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/NodeRareData.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/NodeRareData.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLOptGroupElement.h View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLOptionElement.h View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download

Dependent Patchsets:

Issue 2001453002 Patch 360001
Issue 2001453002 Patch 380001

Messages

Total messages: 25 (25 generated)
nainar
Description was changed from ========== Storage of ComputedStyle separate from LayoutObject. Part of stage 1 ...
4 years, 5 months ago (2016-07-05 00:20:41 UTC) #1
nainar
The CQ bit was checked by nainar@chromium.org to run a CQ dry run
4 years, 5 months ago (2016-07-15 05:42:45 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2119263002/40001
4 years, 5 months ago (2016-07-15 05:42:57 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 5 months ago (2016-07-15 05:44:35 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/36300) ios-device-gn on ...
4 years, 5 months ago (2016-07-15 05:44:36 UTC) #5
nainar
The CQ bit was checked by nainar@chromium.org to run a CQ dry run
4 years, 5 months ago (2016-07-18 01:29:19 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2119263002/60001
4 years, 5 months ago (2016-07-18 01:29:23 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 5 months ago (2016-07-18 01:39:07 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_android/builds/97333)
4 years, 5 months ago (2016-07-18 01:39:08 UTC) #9
nainar
The CQ bit was checked by nainar@chromium.org to run a CQ dry run
4 years, 5 months ago (2016-07-18 01:57:01 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2119263002/80001
4 years, 5 months ago (2016-07-18 01:57:08 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 5 months ago (2016-07-18 03:44:26 UTC) #12
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-07-18 03:44:26 UTC) #13
nainar
The CQ bit was checked by nainar@chromium.org to run a CQ dry run
4 years, 4 months ago (2016-07-28 03:12:11 UTC) #14
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2119263002/100001
4 years, 4 months ago (2016-07-28 03:12:29 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 4 months ago (2016-07-28 03:14:26 UTC) #16
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/42674) ios-device-gn on ...
4 years, 4 months ago (2016-07-28 03:14:27 UTC) #17
nainar
The CQ bit was checked by nainar@chromium.org to run a CQ dry run
4 years, 4 months ago (2016-07-28 03:26:18 UTC) #18
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2119263002/120001
4 years, 4 months ago (2016-07-28 03:26:52 UTC) #19
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 4 months ago (2016-07-28 03:37:23 UTC) #20
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_android/builds/103178) linux_chromium_chromeos_ozone_rel_ng on ...
4 years, 4 months ago (2016-07-28 03:37:24 UTC) #21
nainar
The CQ bit was checked by nainar@chromium.org to run a CQ dry run
4 years, 4 months ago (2016-07-28 04:38:02 UTC) #22
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2119263002/140001
4 years, 4 months ago (2016-07-28 04:38:15 UTC) #23
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 4 months ago (2016-07-28 07:41:26 UTC) #24
commit-bot: I haz the power
4 years, 4 months ago (2016-07-28 07:41:28 UTC) #25 
Dry run: This issue passed the CQ dry run.

Powered by Google App Engine
This is Rietveld 408576698