Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Unified Diff: chrome/android/java/res/layout/payment_request_editor_label.xml

Issue 2116583002: Credit card editor for PaymentRequest UI. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update comments in personal_data_manager_android.h Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/res/layout/payment_request_editor_label.xml
diff --git a/chrome/android/java/res/layout/payment_request_editor_label.xml b/chrome/android/java/res/layout/payment_request_editor_label.xml
new file mode 100644
index 0000000000000000000000000000000000000000..4d74f376fe0a2adbce7477545331be81117faedf
--- /dev/null
+++ b/chrome/android/java/res/layout/payment_request_editor_label.xml
@@ -0,0 +1,47 @@
+<?xml version="1.0" encoding="utf-8"?>
+<!-- Copyright 2016 The Chromium Authors. All rights reserved.
+ Use of this source code is governed by a BSD-style license that can be
+ found in the LICENSE file. -->
+
+<RelativeLayout
+ xmlns:android="http://schemas.android.com/apk/res/android"
+ android:layout_width="match_parent"
+ android:layout_height="wrap_content"
+ android:paddingBottom="@dimen/pref_autofill_content_spacing"
gone 2016/07/13 21:12:59 Use margins when separating items from other items
please use gerrit instead 2016/07/14 17:21:43 Done.
+ android:paddingStart="@dimen/pref_autofill_field_horizontal_padding"
+ android:paddingEnd="@dimen/pref_autofill_field_horizontal_padding">
+
+ <ImageView
+ android:id="@+id/icon"
+ android:layout_width="wrap_content"
+ android:layout_height="wrap_content"
+ android:layout_alignParentEnd="true"
+ android:importantForAccessibility="no"
gone 2016/07/13 21:12:59 Group the android:layout_ attributes together
please use gerrit instead 2016/07/14 17:21:43 Done.
+ android:layout_centerVertical="true" />
+
+ <TextView
+ android:id="@+id/label"
+ android:layout_width="wrap_content"
+ android:layout_height="wrap_content"
+ android:layout_toStartOf="@id/icon"
+ android:layout_alignParentStart="true"
gone 2016/07/13 21:12:59 Should this add layout_alignParentTop="true"?
please use gerrit instead 2016/07/14 17:21:43 Done.
+ android:textAppearance="@style/PreferenceFloatLabelTextAppearance" />
+
+ <TextView
+ android:id="@+id/midlabel"
+ android:layout_width="wrap_content"
+ android:layout_height="wrap_content"
+ android:layout_below="@id/label"
+ android:layout_toStartOf="@id/icon"
+ android:layout_alignParentStart="true"
+ android:textAppearance="@style/PreferenceFloatLabelTextAppearance" />
+
+ <TextView
+ android:id="@+id/sublabel"
+ android:layout_width="wrap_content"
+ android:layout_height="wrap_content"
+ android:layout_below="@id/midlabel"
+ android:layout_toStartOf="@id/icon"
+ android:layout_alignParentStart="true"
+ android:textAppearance="@style/PreferenceFloatLabelTextAppearance" />
+</RelativeLayout>

Powered by Google App Engine
This is Rietveld 408576698