chrome/android/java/res/layout/payment_request_editor_label.xml - Issue 2116583002: Credit card editor for PaymentRequest UI.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/layout/payment_request_editor_label.xml

Issue 2116583002: Credit card editor for PaymentRequest UI. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update comments in personal_data_manager_android.h Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/android/java/res/layout/payment_request_editor_icons.xml ('K') | « chrome/android/java/res/layout/payment_request_editor_icons.xml ('k') | chrome/android/java/res/values/ids.xml » ('j') | chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <!-- Copyright 2016 The Chromium Authors. All rights reserved.

	3 Use of this source code is governed by a BSD-style license that can be

	4 found in the LICENSE file. -->

	5

	6 <RelativeLayout

	7 xmlns:android="http://schemas.android.com/apk/res/android"

	8 android:layout_width="match_parent"

	9 android:layout_height="wrap_content"

	10 android:paddingBottom="@dimen/pref_autofill_content_spacing"
	gone 2016/07/13 21:12:59 Use margins when separating items from other items Use margins when separating items from other items, not padding. This currently knocks the icon off-center. please use gerrit instead 2016/07/14 17:21:43 Done. Show quoted text On 2016/07/13 21:12:59, dfalcantara wrote: > Use margins when separating items from other items, not padding. This currently > knocks the icon off-center. Done.
	11 android:paddingStart="@dimen/pref_autofill_field_horizontal_padding"

	12 android:paddingEnd="@dimen/pref_autofill_field_horizontal_padding">

	13

	14 <ImageView

	15 android:id="@+id/icon"

	16 android:layout_width="wrap_content"

	17 android:layout_height="wrap_content"

	18 android:layout_alignParentEnd="true"

	19 android:importantForAccessibility="no"
	gone 2016/07/13 21:12:59 Group the android:layout_ attributes together Group the android:layout_ attributes together please use gerrit instead 2016/07/14 17:21:43 Done. Show quoted text On 2016/07/13 21:12:59, dfalcantara wrote: > Group the android:layout_ attributes together Done.
	20 android:layout_centerVertical="true" />

	21

	22 <TextView

	23 android:id="@+id/label"

	24 android:layout_width="wrap_content"

	25 android:layout_height="wrap_content"

	26 android:layout_toStartOf="@id/icon"

	27 android:layout_alignParentStart="true"
	gone 2016/07/13 21:12:59 Should this add layout_alignParentTop="true"? Should this add layout_alignParentTop="true"? please use gerrit instead 2016/07/14 17:21:43 Done. Show quoted text On 2016/07/13 21:12:59, dfalcantara wrote: > Should this add layout_alignParentTop="true"? Done.
	28 android:textAppearance="@style/PreferenceFloatLabelTextAppearance" />

	29

	30 <TextView

	31 android:id="@+id/midlabel"

	32 android:layout_width="wrap_content"

	33 android:layout_height="wrap_content"

	34 android:layout_below="@id/label"

	35 android:layout_toStartOf="@id/icon"

	36 android:layout_alignParentStart="true"

	37 android:textAppearance="@style/PreferenceFloatLabelTextAppearance" />

	38

	39 <TextView

	40 android:id="@+id/sublabel"

	41 android:layout_width="wrap_content"

	42 android:layout_height="wrap_content"

	43 android:layout_below="@id/midlabel"

	44 android:layout_toStartOf="@id/icon"

	45 android:layout_alignParentStart="true"

	46 android:textAppearance="@style/PreferenceFloatLabelTextAppearance" />

	47 </RelativeLayout>

OLD	NEW