Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issue 211213003: Fix spelling in histogtrams.xml;comment in header; format in cc file. (Closed)

Created:
6 years, 9 months ago by jar (doing other things)
Modified:
6 years, 9 months ago
Reviewers:
wtc, Ryan Hamilton
CC:
chromium-reviews, asvitkine+watch_chromium.org, cbentzel+watch_chromium.org, mmenke, wtc
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix other comment on nearby line #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
M net/base/net_error_list.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M net/udp/udp_socket_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jar (doing other things)
6 years, 9 months ago (2014-03-25 17:02:14 UTC) #1
Ryan Hamilton
LGTM. Since the changes to the .h and .cc are not "urgent" (and there are ...
6 years, 9 months ago (2014-03-25 17:06:34 UTC) #2
wtc
Review comments on patch set 1: Jim, I'll be happy to make the changes I ...
6 years, 9 months ago (2014-03-25 17:27:46 UTC) #3
jar (doing other things)
I'll do the larger changes... but wanted to land an xml change sooner... and tossed ...
6 years, 9 months ago (2014-03-25 17:31:11 UTC) #4
jar (doing other things)
6 years, 9 months ago (2014-03-25 18:57:34 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r259277 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698