Fix spelling in histogtrams.xml;comment in header; format in cc file.

r=rch
BUG=355222
R=rch@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259277

[Ryan Hamilton, 2014-03-25 17:06:34]

LGTM. Since the changes to the .h and .cc are not "urgent" (and there are more
changes needed to these files per wtc's comments) I would recommend that you
split them off into their own CL. Then you can land the histogram change
immediately. Your call, though.

[wtc, 2014-03-25 17:27:46]

Review comments on patch set 1:

Jim, I'll be happy to make the changes I suggested for you.

https://chromiumcodereview.appspot.com/211213003/diff/1/net/base/net_error_li...
File net/base/net_error_list.h (right):

https://chromiumcodereview.appspot.com/211213003/diff/1/net/base/net_error_li...
net/base/net_error_list.h:316: // Failed to increase the socket's receive buffer
size as requested

Please also fix this comment.

https://chromiumcodereview.appspot.com/211213003/diff/1/net/udp/udp_socket_wi...
File net/udp/udp_socket_win.cc (left):

https://chromiumcodereview.appspot.com/211213003/diff/1/net/udp/udp_socket_wi...
net/udp/udp_socket_win.cc:394: reinterpret_cast<const char*>(&size),
sizeof(size));

The indentation of this should wait until the other changes I suggested. I think
you should definitely check the return value of setsockopt, and that will
require reformatting this setsockopt call.

[jar (doing other things), 2014-03-25 17:31:11]

I'll do the larger changes... but wanted to land an xml change sooner...
and tossed in the comment and formatting changes.


On Tue, Mar 25, 2014 at 10:27 AM, <wtc@chromium.org> wrote:

> Review comments on patch set 1:
>
> Jim, I'll be happy to make the changes I suggested for you.
>
>
> https://chromiumcodereview.appspot.com/211213003/diff/1/
> net/base/net_error_list.h
> File net/base/net_error_list.h (right):
>
> https://chromiumcodereview.appspot.com/211213003/diff/1/
> net/base/net_error_list.h#newcode316
> net/base/net_error_list.h:316: // Failed to increase the socket's
> receive buffer size as requested
>
> Please also fix this comment.
>
> https://chromiumcodereview.appspot.com/211213003/diff/1/
> net/udp/udp_socket_win.cc
> File net/udp/udp_socket_win.cc (left):
>
> https://chromiumcodereview.appspot.com/211213003/diff/1/
> net/udp/udp_socket_win.cc#oldcode394
> net/udp/udp_socket_win.cc:394: reinterpret_cast<const char*>(&size),
> sizeof(size));
>
> The indentation of this should wait until the other changes I suggested.
> I think you should definitely check the return value of setsockopt, and
> that will require reformatting this setsockopt call.
>
> https://chromiumcodereview.appspot.com/211213003/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[jar (doing other things), 2014-03-25 18:57:34]

Committed patchset #3 manually as r259277 (presubmit successful).