extensions: Remove chrome.webSocketProxyPrivate API

extensions: Remove chrome.webSocketProxyPrivate API

The private API is no longer in use.

BUG=244359
TEST=none
R=asargent@chromium.org, dpolukhin@chromium.org, thestig@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215190

[satorux1, 2013-07-31 04:50:14]

dpolukhin@ for everything
asargent@ for chrome/{browser,common}/extensions
thestig@ for .gypi changes

[Dmitry Polukhin, 2013-07-31 05:42:33]

Thank you for doing this cleanup!

It looks like we can remove more i.e. we don't need permission
kWebSocketProxyPrivate and test for it
chrome/test/data/extensions/api_test/web_socket_proxy_private.

[satorux1, 2013-07-31 05:54:19]

Good catch! Removed the stuff you mentioned.

[Lei Zhang, 2013-07-31 17:09:41]

gyp changes lgtm

[Dmitry Polukhin, 2013-07-31 17:46:47]

LGTM but I think we can remove even a bit more, we don't need reference to
webSocketProxyPrivate in:

chrome/common/extensions/api/_permission_features.json
chrome/test/ext_auto/auto_provider/manifest.json

I would grep sources for webSocketProxyPrivate case insensitive to makes sure
that nothing left.

[asargent_no_longer_on_chrome, 2013-07-31 23:06:55]

LGTM, thanks for the cleanup. Agree that there are a few more places the literal
string could be removed.

[satorux1, 2013-08-01 01:16:02]

Removed a bit more. We should be good to go now.

% git grep  -i webSocketProxyPrivate 
chrome/browser/extensions/extension_function_histogram_value.h: 
DELETED_WEBSOCKETPROXYPRIVATE_GETPASSPOR
chrome/browser/extensions/extension_function_histogram_value.h: 
DELETED_WEBSOCKETPROXYPRIVATE_GETURLFORT
tools/metrics/histograms/histograms.xml:  <int value="387"
label="WEBSOCKETPROXYPRIVATE_GETPASSPORTFORTCP
tools/metrics/histograms/histograms.xml:  <int value="391"
label="WEBSOCKETPROXYPRIVATE_GETURLFORTCP"/>

The part in histograms.xml is auto generated so we don't have to worry about.
 
% git grep  -i web_socket_proxy
%

[commit-bot: I haz the power, 2013-08-01 07:57:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/satorux@chromium.org/21115004/28001

[commit-bot: I haz the power, 2013-08-01 08:01:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/satorux@chromium.org/21115004/38001

[commit-bot: I haz the power, 2013-08-01 12:15:49]

Failed to apply patch for chrome/common/extensions/api/api.gyp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/common/extensions/api/api.gyp
  Hunk #1 FAILED at 104.
  1 out of 1 hunk FAILED -- saving rejects to file
chrome/common/extensions/api/api.gyp.rej

Patch:       chrome/common/extensions/api/api.gyp
Index: chrome/common/extensions/api/api.gyp
diff --git a/chrome/common/extensions/api/api.gyp
b/chrome/common/extensions/api/api.gyp
index
f81984792aa435aa36d71e3f63e1ce9d5aa6926b..ab84a6600e879a35e7e519b5729d906cc6dc5013
100644
--- a/chrome/common/extensions/api/api.gyp
+++ b/chrome/common/extensions/api/api.gyp
@@ -104,7 +104,6 @@
           'wallpaper_private.json',
           'web_navigation.json',
           'web_request.json',
-          'web_socket_proxy_private.json',
           'webview.json',
           'windows.json',
         ],

[satorux1, 2013-08-02 01:42:33]

Committed patchset #5 manually as r215190 (presubmit successful).