Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 21115004: extensions: Remove chrome.webSocketProxyPrivate API (Closed)

Created:
7 years, 4 months ago by satorux1
Modified:
7 years, 4 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org
Visibility:
Public.

Description

extensions: Remove chrome.webSocketProxyPrivate API The private API is no longer in use. BUG=244359 TEST=none R=asargent@chromium.org, dpolukhin@chromium.org, thestig@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215190

Patch Set 1 #

Patch Set 2 : remove more #

Patch Set 3 : rebase #

Patch Set 4 : remove a bit more #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2921 lines) Patch
M chrome/browser/chrome_notification_types.h View 1 2 3 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 1 2 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/extensions/input_method_event_router.cc View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/browser/chromeos/web_socket_proxy.h View 1 chunk +0 lines, -45 lines 0 comments Download
D chrome/browser/chromeos/web_socket_proxy.cc View 1 chunk +0 lines, -1918 lines 0 comments Download
D chrome/browser/chromeos/web_socket_proxy_controller.h View 1 chunk +0 lines, -32 lines 0 comments Download
D chrome/browser/chromeos/web_socket_proxy_controller.cc View 1 chunk +0 lines, -161 lines 0 comments Download
D chrome/browser/chromeos/web_socket_proxy_helper.h View 1 chunk +0 lines, -33 lines 0 comments Download
D chrome/browser/chromeos/web_socket_proxy_helper.cc View 1 chunk +0 lines, -70 lines 0 comments Download
D chrome/browser/chromeos/web_socket_proxy_helper_unittest.cc View 1 chunk +0 lines, -83 lines 0 comments Download
D chrome/browser/extensions/api/web_socket_proxy_private/web_socket_proxy_private_api.h View 1 chunk +0 lines, -115 lines 0 comments Download
D chrome/browser/extensions/api/web_socket_proxy_private/web_socket_proxy_private_api.cc View 1 chunk +0 lines, -208 lines 0 comments Download
D chrome/browser/extensions/api/web_socket_proxy_private/web_socket_proxy_private_apitest.cc View 1 chunk +0 lines, -28 lines 0 comments Download
M chrome/browser/extensions/extension_function_histogram_value.h View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/internal_auth.h View 1 2 chunks +0 lines, -8 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 2 3 4 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 2 3 4 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/api/_api_features.json View 1 2 3 4 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/extensions/api/_permission_features.json View 1 2 3 4 1 chunk +0 lines, -11 lines 0 comments Download
M chrome/common/extensions/api/api.gyp View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/api/web_socket_proxy_private.json View 1 chunk +0 lines, -81 lines 0 comments Download
M chrome/common/extensions/docs/server2/test_data/file_system/stat View 1 2 3 2 chunks +0 lines, -28 lines 0 comments Download
M chrome/common/extensions/docs/server2/test_data/file_system/stat_result.json View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/permissions/api_permission.h View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/permissions/chrome_api_permissions.cc View 1 2 3 4 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/extensions/permissions/permission_set_unittest.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
D chrome/test/data/extensions/api_test/web_socket_proxy_private/background.js View 1 1 chunk +0 lines, -56 lines 0 comments Download
D chrome/test/data/extensions/api_test/web_socket_proxy_private/manifest.json View 1 1 chunk +0 lines, -11 lines 0 comments Download
M chrome/test/ext_auto/auto_provider/manifest.json View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
satorux1
dpolukhin@ for everything asargent@ for chrome/{browser,common}/extensions thestig@ for .gypi changes
7 years, 4 months ago (2013-07-31 04:50:14 UTC) #1
Dmitry Polukhin
Thank you for doing this cleanup! It looks like we can remove more i.e. we ...
7 years, 4 months ago (2013-07-31 05:42:33 UTC) #2
satorux1
Good catch! Removed the stuff you mentioned.
7 years, 4 months ago (2013-07-31 05:54:19 UTC) #3
Lei Zhang
gyp changes lgtm
7 years, 4 months ago (2013-07-31 17:09:41 UTC) #4
Dmitry Polukhin
LGTM but I think we can remove even a bit more, we don't need reference ...
7 years, 4 months ago (2013-07-31 17:46:47 UTC) #5
asargent_no_longer_on_chrome
LGTM, thanks for the cleanup. Agree that there are a few more places the literal ...
7 years, 4 months ago (2013-07-31 23:06:55 UTC) #6
satorux1
Removed a bit more. We should be good to go now. % git grep -i ...
7 years, 4 months ago (2013-08-01 01:16:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/satorux@chromium.org/21115004/28001
7 years, 4 months ago (2013-08-01 07:57:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/satorux@chromium.org/21115004/38001
7 years, 4 months ago (2013-08-01 08:01:57 UTC) #9
commit-bot: I haz the power
Failed to apply patch for chrome/common/extensions/api/api.gyp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 4 months ago (2013-08-01 12:15:49 UTC) #10
satorux1
7 years, 4 months ago (2013-08-02 01:42:33 UTC) #11
Message was sent while issue was closed.
Committed patchset #5 manually as r215190 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698