Make is checks work on JavaScriptFunction objects.

Make is checks work on JavaScriptFunction objects.

BUG=
R=sra@google.com

Committed: https://github.com/dart-lang/sdk/commit/595ec1d7850e0d9674bfabc725a0528484ab2018

[Jacob, 2016-06-29 23:18:11]

jacobr@google.com changed reviewers:
+ sra@google.com

[sra1, 2016-06-30 17:57:13]

lgtm

https://chromiumcodereview.appspot.com/2110273003/diff/1/pkg/compiler/lib/src...
File pkg/compiler/lib/src/js_backend/js_interop_analysis.dart (right):

https://chromiumcodereview.appspot.com/2110273003/diff/1/pkg/compiler/lib/src...
pkg/compiler/lib/src/js_backend/js_interop_analysis.dart:201: new
List<DartType>.generate(16, (_) => const DynamicType()));
This is ok since it is a one-of thing, but consider List.filled.

[Jacob, 2016-07-01 18:27:50]

https://chromiumcodereview.appspot.com/2110273003/diff/1/pkg/compiler/lib/src...
File pkg/compiler/lib/src/js_backend/js_interop_analysis.dart (right):

https://chromiumcodereview.appspot.com/2110273003/diff/1/pkg/compiler/lib/src...
pkg/compiler/lib/src/js_backend/js_interop_analysis.dart:201: new
List<DartType>.generate(16, (_) => const DynamicType()));
On 2016/06/30 17:57:13, sra1 wrote:
> This is ok since it is a one-of thing, but consider List.filled.

filled is better. Forgot we had that constructor.

[Jacob, 2016-07-01 18:31:33]

Description was changed from

==========
Make is checks work on JavaScriptFunction objects.

BUG=
==========

to

==========
Make is checks work on JavaScriptFunction objects.

BUG=
R=sra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/595ec1d7850e0d9674bfabc725a0528484ab2018
==========

[Jacob, 2016-07-01 18:31:34]

Committed patchset #1 (id:1) manually as
595ec1d7850e0d9674bfabc725a0528484ab2018 (presubmit successful).