Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Unified Diff: chromeos/network/onc/onc_certificate_importer_impl_unittest.cc

Issue 21030009: Make element removal methods in DictionaryValue and ListValue take scoped_ptr's as outparams. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: sync Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/webdriver/webdriver_session.cc ('k') | chromeos/network/onc/onc_validator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/network/onc/onc_certificate_importer_impl_unittest.cc
diff --git a/chromeos/network/onc/onc_certificate_importer_impl_unittest.cc b/chromeos/network/onc/onc_certificate_importer_impl_unittest.cc
index 497a6103b0c7a3310c54e52add00b54ac28b3b0d..7a525d1494086cde032b3e77a7397fd01ae23bf2 100644
--- a/chromeos/network/onc/onc_certificate_importer_impl_unittest.cc
+++ b/chromeos/network/onc/onc_certificate_importer_impl_unittest.cc
@@ -80,11 +80,11 @@ class ONCCertificateImporterImplTest : public testing::Test {
void AddCertificatesFromFile(std::string filename, bool expected_success) {
scoped_ptr<base::DictionaryValue> onc =
test_utils::ReadTestDictionary(filename);
- base::Value* certificates_value = NULL;
+ scoped_ptr<base::Value> certificates_value;
base::ListValue* certificates = NULL;
onc->RemoveWithoutPathExpansion(toplevel_config::kCertificates,
&certificates_value);
- certificates_value->GetAsList(&certificates);
+ certificates_value.release()->GetAsList(&certificates);
onc_certificates_.reset(certificates);
web_trust_certificates_.clear();
« no previous file with comments | « chrome/test/webdriver/webdriver_session.cc ('k') | chromeos/network/onc/onc_validator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698