Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Unified Diff: chrome/test/webdriver/webdriver_session.cc

Issue 21030009: Make element removal methods in DictionaryValue and ListValue take scoped_ptr's as outparams. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: sync Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/webdriver/webdriver_session.cc
diff --git a/chrome/test/webdriver/webdriver_session.cc b/chrome/test/webdriver/webdriver_session.cc
index 51f901e9bc01e922e073d28149d6c6bd3d76e500..1c87b2bf5c072e9e76e0c06fe5c3136bbc867cb0 100644
--- a/chrome/test/webdriver/webdriver_session.cc
+++ b/chrome/test/webdriver/webdriver_session.cc
@@ -560,7 +560,8 @@ Error* Session::MouseDoubleClick() {
return error;
}
-Error* Session::GetCookies(const std::string& url, base::ListValue** cookies) {
+Error* Session::GetCookies(const std::string& url,
+ scoped_ptr<base::ListValue>* cookies) {
Error* error = NULL;
RunSessionTask(base::Bind(
&Automation::GetCookies,
« no previous file with comments | « chrome/test/webdriver/webdriver_session.h ('k') | chromeos/network/onc/onc_certificate_importer_impl_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698