chrome/test/webdriver/webdriver_session.h - Issue 21030009: Make element removal methods in DictionaryValue and ListValue take scoped_ptr's as outparams.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/webdriver/webdriver_session.h

Issue 21030009: Make element removal methods in DictionaryValue and ListValue take scoped_ptr's as outparams. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: sync Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/test/webdriver/webdriver_session.h

diff --git a/chrome/test/webdriver/webdriver_session.h b/chrome/test/webdriver/webdriver_session.h

index 0b81645709287e308af30299aa016aa611e4261a..413a522e97064eecd14b5e4749edc639dc1c3fe3 100644

--- a/chrome/test/webdriver/webdriver_session.h

+++ b/chrome/test/webdriver/webdriver_session.h

@@ -143,7 +143,8 @@ class Session {

#if !defined(NO_TCMALLOC) && (defined(OS_LINUX) || defined(OS_CHROMEOS))

Error* HeapProfilerDump(const std::string& reason);

#endif // !defined(NO_TCMALLOC) && (defined(OS_LINUX) || defined(OS_CHROMEOS))

- Error* GetCookies(const std::string& url, base::ListValue** cookies);

+ Error* GetCookies(const std::string& url,

+ scoped_ptr<base::ListValue>* cookies);

Error* DeleteCookie(const std::string& url, const std::string& cookie_name);

Error* SetCookie(const std::string& url, base::DictionaryValue* cookie_dict);

« no previous file with comments | « chrome/test/webdriver/webdriver_automation.cc ('k') | chrome/test/webdriver/webdriver_session.cc » ('j') | no next file with comments »