chrome/browser/chromeos/policy/network_configuration_updater_impl_cros_unittest.cc - Issue 21030009: Make element removal methods in DictionaryValue and ListValue take scoped_ptr's as outparams.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/policy/network_configuration_updater_impl_cros_unittest.cc

Issue 21030009: Make element removal methods in DictionaryValue and ListValue take scoped_ptr's as outparams. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: sync Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/extensions/external_cache.cc ('k') | chrome/browser/content_settings/content_settings_policy_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/policy/network_configuration_updater_impl_cros_unittest.cc

diff --git a/chrome/browser/chromeos/policy/network_configuration_updater_impl_cros_unittest.cc b/chrome/browser/chromeos/policy/network_configuration_updater_impl_cros_unittest.cc

index b32dee12bc7c3d061ac952f877e258adce8a3f1a..620871118e2f678a4920c6801734e3d23ab13829 100644

--- a/chrome/browser/chromeos/policy/network_configuration_updater_impl_cros_unittest.cc

+++ b/chrome/browser/chromeos/policy/network_configuration_updater_impl_cros_unittest.cc

@@ -107,20 +107,20 @@ class NetworkConfigurationUpdaterTest : public testing::Test {

scoped_ptr<base::DictionaryValue> fake_toplevel_onc =

onc::ReadDictionaryFromJson(kFakeONC);

- base::Value* network_configs_value = NULL;

+ scoped_ptr<base::Value> network_configs_value;

base::ListValue* network_configs = NULL;

fake_toplevel_onc->RemoveWithoutPathExpansion(

onc::toplevel_config::kNetworkConfigurations,

&network_configs_value);

- network_configs_value->GetAsList(&network_configs);

+ network_configs_value.release()->GetAsList(&network_configs);

fake_network_configs_.reset(network_configs);

- base::Value* certs_value = NULL;

+ scoped_ptr<base::Value> certs_value;

base::ListValue* certs = NULL;

fake_toplevel_onc->RemoveWithoutPathExpansion(

onc::toplevel_config::kCertificates,

&certs_value);

- certs_value->GetAsList(&certs);

+ certs_value.release()->GetAsList(&certs);

fake_certificates_.reset(certs);

}