Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1249)

Unified Diff: chrome/browser/chromeos/extensions/external_cache.cc

Issue 21030009: Make element removal methods in DictionaryValue and ListValue take scoped_ptr's as outparams. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: sync Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/extensions/external_cache.cc
diff --git a/chrome/browser/chromeos/extensions/external_cache.cc b/chrome/browser/chromeos/extensions/external_cache.cc
index 3e19c658fb94a4a9f0d82e40c0706c032b78f591..cee854493368afacdeb0e6492f41cf85970d6f1b 100644
--- a/chrome/browser/chromeos/extensions/external_cache.cc
+++ b/chrome/browser/chromeos/extensions/external_cache.cc
@@ -338,9 +338,9 @@ void ExternalCache::OnCacheUpdated(scoped_ptr<base::DictionaryValue> prefs) {
extensions::ExternalProviderImpl::kExternalCrx, &crx_path) ||
cached_entry->HasKey(
extensions::ExternalProviderImpl::kKeepIfPresent)) {
- base::Value* value = NULL;
+ scoped_ptr<base::Value> value;
prefs->Remove(it.key(), &value);
- cached_extensions_->Set(it.key(), value);
+ cached_extensions_->Set(it.key(), value.release());
}
}
}
« no previous file with comments | « base/values_unittest.cc ('k') | chrome/browser/chromeos/policy/network_configuration_updater_impl_cros_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698