Changes argument passing to use options objects

Changes argument passing to use options objects

Options objects are specific to the test type, and are named tuples, so
they are also immutable.

This is a precursor to the host-driven refactor.

BUG=176323
NOTRY=True

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215054

[gkanwar1, 2013-07-30 22:23:53]

ptal

[frankf, 2013-07-31 00:14:00]

https://codereview.chromium.org/21008004/diff/1/build/android/pylib/browserte...
File build/android/pylib/browsertests/setup.py (right):

https://codereview.chromium.org/21008004/diff/1/build/android/pylib/browserte...
build/android/pylib/browsertests/setup.py:5: """Generate test runner factory and
tests for content_browsertests."""
Always rebase, this file is no more.

https://codereview.chromium.org/21008004/diff/1/build/android/pylib/test_opti...
File build/android/pylib/test_options.py (right):

https://codereview.chromium.org/21008004/diff/1/build/android/pylib/test_opti...
build/android/pylib/test_options.py:5: """Defines named tuples of contains
options relevant to each test type."""
Just move these to test_runner

[gkanwar1, 2013-07-31 18:07:06]

Rebased and put out fires, ptal.

https://codereview.chromium.org/21008004/diff/1/build/android/pylib/browserte...
File build/android/pylib/browsertests/setup.py (right):

https://codereview.chromium.org/21008004/diff/1/build/android/pylib/browserte...
build/android/pylib/browsertests/setup.py:5: """Generate test runner factory and
tests for content_browsertests."""
On 2013/07/31 00:14:00, frankf wrote:
> Always rebase, this file is no more.

Done.

https://codereview.chromium.org/21008004/diff/1/build/android/pylib/test_opti...
File build/android/pylib/test_options.py (right):

https://codereview.chromium.org/21008004/diff/1/build/android/pylib/test_opti...
build/android/pylib/test_options.py:5: """Defines named tuples of contains
options relevant to each test type."""
On 2013/07/31 00:14:00, frankf wrote:
> Just move these to test_runner

The problem with that is that we need to import this file in
pylib/uiautomator/test_runner.py, since it creates an InstrumentationOptions
object to pass to the super method.

[frankf, 2013-07-31 19:03:56]

https://codereview.chromium.org/21008004/diff/8001/build/android/pylib/instru...
File build/android/pylib/instrumentation/test_runner.py (right):

https://codereview.chromium.org/21008004/diff/8001/build/android/pylib/instru...
build/android/pylib/instrumentation/test_runner.py:58: options relevant to
running instrumentation tests.
too verbose.

test_options: An InstrumentationOptions object.

https://codereview.chromium.org/21008004/diff/8001/build/android/pylib/test_o...
File build/android/pylib/test_options.py (right):

https://codereview.chromium.org/21008004/diff/8001/build/android/pylib/test_o...
build/android/pylib/test_options.py:5: """Defines named tuples of contains
options relevant to each test type."""
Let's move each option to the respective subdir then.

[gkanwar1, 2013-07-31 19:09:29]

https://codereview.chromium.org/21008004/diff/8001/build/android/pylib/instru...
File build/android/pylib/instrumentation/test_runner.py (right):

https://codereview.chromium.org/21008004/diff/8001/build/android/pylib/instru...
build/android/pylib/instrumentation/test_runner.py:58: options relevant to
running instrumentation tests.
On 2013/07/31 19:03:56, frankf wrote:
> too verbose.
> 
> test_options: An InstrumentationOptions object.

Done.

https://codereview.chromium.org/21008004/diff/8001/build/android/pylib/test_o...
File build/android/pylib/test_options.py (right):

https://codereview.chromium.org/21008004/diff/8001/build/android/pylib/test_o...
build/android/pylib/test_options.py:5: """Defines named tuples of contains
options relevant to each test type."""
On 2013/07/31 19:03:56, frankf wrote:
> Let's move each option to the respective subdir then.

We still need to put common options in a common location though. I think it
makes sense to keep all of these options in one place so we can see what options
are relevant to every test in one common location.

[gkanwar1, 2013-07-31 22:12:11]

On 2013/07/31 19:09:29, gkanwar1 wrote:
>
https://codereview.chromium.org/21008004/diff/8001/build/android/pylib/instru...
> File build/android/pylib/instrumentation/test_runner.py (right):
> 
>
https://codereview.chromium.org/21008004/diff/8001/build/android/pylib/instru...
> build/android/pylib/instrumentation/test_runner.py:58: options relevant to
> running instrumentation tests.
> On 2013/07/31 19:03:56, frankf wrote:
> > too verbose.
> > 
> > test_options: An InstrumentationOptions object.
> 
> Done.
> 
>
https://codereview.chromium.org/21008004/diff/8001/build/android/pylib/test_o...
> File build/android/pylib/test_options.py (right):
> 
>
https://codereview.chromium.org/21008004/diff/8001/build/android/pylib/test_o...
> build/android/pylib/test_options.py:5: """Defines named tuples of contains
> options relevant to each test type."""
> On 2013/07/31 19:03:56, frankf wrote:
> > Let's move each option to the respective subdir then.
> 
> We still need to put common options in a common location though. I think it
> makes sense to keep all of these options in one place so we can see what
options
> are relevant to every test in one common location.

Moved the test options into the individual test types at Frank's suggestion.
Also fixed up host-driven tests. Ptal, thanks!

[frankf, 2013-07-31 22:16:28]

https://codereview.chromium.org/21008004/diff/23001/build/android/pylib/gtest...
File build/android/pylib/gtest/setup.py (right):

https://codereview.chromium.org/21008004/diff/23001/build/android/pylib/gtest...
build/android/pylib/gtest/setup.py:272: gtest_filter = test_options.gtest_filter
NO need for intermediate variables.

https://codereview.chromium.org/21008004/diff/23001/build/android/test_runner.py
File build/android/test_runner.py (right):

https://codereview.chromium.org/21008004/diff/23001/build/android/test_runner...
build/android/test_runner.py:28: from pylib.instrumentation.test_options import
InstrumentationOptions
Don't import individual classes

[gkanwar1, 2013-07-31 22:54:41]

https://codereview.chromium.org/21008004/diff/23001/build/android/pylib/gtest...
File build/android/pylib/gtest/setup.py (right):

https://codereview.chromium.org/21008004/diff/23001/build/android/pylib/gtest...
build/android/pylib/gtest/setup.py:272: gtest_filter = test_options.gtest_filter
On 2013/07/31 22:16:28, frankf wrote:
> NO need for intermediate variables.

Done.

https://codereview.chromium.org/21008004/diff/23001/build/android/test_runner.py
File build/android/test_runner.py (right):

https://codereview.chromium.org/21008004/diff/23001/build/android/test_runner...
build/android/test_runner.py:28: from pylib.instrumentation.test_options import
InstrumentationOptions
On 2013/07/31 22:16:28, frankf wrote:
> Don't import individual classes

Done.

[frankf, 2013-07-31 23:01:50]

lgtm, thanks.

[gkanwar1, 2013-08-01 16:57:17]

On 2013/07/31 23:01:50, frankf wrote:
> lgtm, thanks.

android_fyi_dbg_triggered and android_x86_dbg appear to be external issues with
the builders themselves. Committing.

[commit-bot: I haz the power, 2013-08-01 16:58:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gkanwar@chromium.org/21008004/31001

[commit-bot: I haz the power, 2013-08-01 16:59:25]

Change committed as 215054