Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Side by Side Diff: build/android/pylib/uiautomator/test_runner.py

Issue 21008004: Changes argument passing to use options objects (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixes imports, removes intermediate variables Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/android/pylib/uiautomator/test_options.py ('k') | build/android/test_runner.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Class for running uiautomator tests on a single device.""" 5 """Class for running uiautomator tests on a single device."""
6 6
7 from pylib.instrumentation import test_options
7 from pylib.instrumentation import test_runner as instr_test_runner 8 from pylib.instrumentation import test_runner as instr_test_runner
8 9
9 10
10 class TestRunner(instr_test_runner.TestRunner): 11 class TestRunner(instr_test_runner.TestRunner):
11 """Responsible for running a series of tests connected to a single device.""" 12 """Responsible for running a series of tests connected to a single device."""
12 13
13 def __init__(self, package_name, build_type, test_data, save_perf_json, 14 def __init__(self, test_options, device, shard_index, test_pkg,
14 screenshot_failures, tool, wait_for_debugger, 15 ports_to_forward):
15 disable_assertions, push_deps, cleanup_test_files, device,
16 shard_index, test_pkg, ports_to_forward):
17 """Create a new TestRunner. 16 """Create a new TestRunner.
18 17
19 Args: 18 Args:
20 package_name: Application package name under test. 19 test_options: A UIAutomatorOptions object.
21 See the super class for all other args. 20 device: Attached android device.
21 shard_index: Shard index.
22 test_pkg: A TestPackage object.
23 ports_to_forward: A list of port numbers for which to set up forwarders.
24 Can be optionally requested by a test case.
22 """ 25 """
23 super(TestRunner, self).__init__( 26 # Create an InstrumentationOptions object to pass to the super class
24 build_type, test_data, save_perf_json, screenshot_failures, tool, 27 instrumentation_options = test_options.InstrumentationOptions(
25 wait_for_debugger, disable_assertions, push_deps, cleanup_test_files, 28 test_options.build_type,
26 device, shard_index, test_pkg, ports_to_forward) 29 test_options.tool,
30 test_options.cleanup_test_files,
31 test_options.push_deps,
32 test_options.annotations,
33 test_options.exclude_annotations,
34 test_options.test_filter,
35 test_options.test_data,
36 test_options.save_perf_json,
37 test_options.screenshot_failures,
38 test_options.disable_assertions,
39 wait_for_debugger=False,
40 test_apk=None)
41 super(TestRunner, self).__init__(instrumentation_options, device,
42 shard_index, test_pkg, ports_to_forward)
27 43
28 self.package_name = package_name 44 self.package_name = test_options.package_name
29 45
30 #override 46 #override
31 def InstallTestPackage(self): 47 def InstallTestPackage(self):
32 self.test_pkg.Install(self.adb) 48 self.test_pkg.Install(self.adb)
33 49
34 #override 50 #override
35 def PushDataDeps(self): 51 def PushDataDeps(self):
36 pass 52 pass
37 53
38 #override 54 #override
39 def _RunTest(self, test, timeout): 55 def _RunTest(self, test, timeout):
40 self.adb.ClearApplicationState(self.package_name) 56 self.adb.ClearApplicationState(self.package_name)
41 if 'Feature:FirstRunExperience' in self.test_pkg.GetTestAnnotations(test): 57 if 'Feature:FirstRunExperience' in self.test_pkg.GetTestAnnotations(test):
42 self.flags.RemoveFlags(['--disable-fre']) 58 self.flags.RemoveFlags(['--disable-fre'])
43 else: 59 else:
44 self.flags.AddFlags(['--disable-fre']) 60 self.flags.AddFlags(['--disable-fre'])
45 return self.adb.RunUIAutomatorTest( 61 return self.adb.RunUIAutomatorTest(
46 test, self.test_pkg.GetPackageName(), timeout) 62 test, self.test_pkg.GetPackageName(), timeout)
OLDNEW
« no previous file with comments | « build/android/pylib/uiautomator/test_options.py ('k') | build/android/test_runner.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698