Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2099053002: Keep more analysis results that don't change when a source is changed. (Closed)

Created:
4 years, 5 months ago by scheglov
Modified:
4 years, 5 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Keep more analysis results that don't change when a source is changed. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/40370cad3284ec89eb313873e8fc7461fadec92e

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+145 lines, -41 lines) Patch
M pkg/analyzer/lib/src/task/dart.dart View 4 chunks +28 lines, -15 lines 1 comment Download
M pkg/analyzer/test/src/context/context_test.dart View 18 chunks +117 lines, -26 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 5 months ago (2016-06-26 04:14:41 UTC) #1
Brian Wilkerson
lgtm https://codereview.chromium.org/2099053002/diff/1/pkg/analyzer/lib/src/task/dart.dart File pkg/analyzer/lib/src/task/dart.dart (right): https://codereview.chromium.org/2099053002/diff/1/pkg/analyzer/lib/src/task/dart.dart#newcode2231 pkg/analyzer/lib/src/task/dart.dart:2231: // TODO(scheglov) Why the target is LibrarySpecificUnit? This ...
4 years, 5 months ago (2016-06-27 13:59:01 UTC) #2
scheglov
4 years, 5 months ago (2016-06-27 16:06:44 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
40370cad3284ec89eb313873e8fc7461fadec92e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698