Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Unified Diff: content/common/mojo/mojo_shell_connection_impl.h

Issue 2096643002: Eliminate MojoApplicationHost (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mah3
Patch Set: . Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/child/mojo/mojo_application.cc ('k') | content/common/mojo/mojo_shell_connection_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/mojo/mojo_shell_connection_impl.h
diff --git a/content/common/mojo/mojo_shell_connection_impl.h b/content/common/mojo/mojo_shell_connection_impl.h
index c1adb5f3a1513f52c5eb6c84e577da75cb37751c..12ef229b59c919f7a4f164540a208282ac2b32cf 100644
--- a/content/common/mojo/mojo_shell_connection_impl.h
+++ b/content/common/mojo/mojo_shell_connection_impl.h
@@ -38,6 +38,7 @@ class MojoShellConnectionImpl
void SetConnectionLostClosure(const base::Closure& closure) override;
void AddEmbeddedShellClient(
std::unique_ptr<shell::ShellClient> shell_client) override;
+ void AddEmbeddedShellClient(shell::ShellClient* shell_client) override;
void AddEmbeddedService(const std::string& name,
const MojoApplicationInfo& info) override;
void AddShellClientRequestHandler(
@@ -60,7 +61,8 @@ class MojoShellConnectionImpl
std::unique_ptr<shell::ShellConnection> shell_connection_;
mojo::BindingSet<shell::mojom::ShellClientFactory> factory_bindings_;
- std::vector<std::unique_ptr<shell::ShellClient>> embedded_shell_clients_;
+ std::vector<shell::ShellClient*> embedded_shell_clients_;
+ std::vector<std::unique_ptr<shell::ShellClient>> owned_shell_clients_;
std::unordered_map<std::string, std::unique_ptr<EmbeddedApplicationRunner>>
embedded_apps_;
std::unordered_map<std::string, ShellClientRequestHandler> request_handlers_;
« no previous file with comments | « content/child/mojo/mojo_application.cc ('k') | content/common/mojo/mojo_shell_connection_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698