chrome/browser/notifications/notification_platform_bridge_mac.mm - Issue 2095223002: Refactor notification operation functionality out of PNS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/notification_platform_bridge_mac.mm

Issue 2095223002: Refactor notification operation functionality out of PNS (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: remove enum suffix Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/notifications/notification_platform_bridge_android.cc ('k') | chrome/browser/notifications/persistent_notification_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/notification_platform_bridge_mac.mm

diff --git a/chrome/browser/notifications/notification_platform_bridge_mac.mm b/chrome/browser/notifications/notification_platform_bridge_mac.mm

index 39efa122f60a5625370714a39ef9e345542a4462..8ceb560269967a3172a769c7e94251788b716b55 100644

--- a/chrome/browser/notifications/notification_platform_bridge_mac.mm

+++ b/chrome/browser/notifications/notification_platform_bridge_mac.mm

@@ -12,6 +12,7 @@

#include "base/strings/sys_string_conversions.h"

#include "chrome/browser/browser_process.h"

#include "chrome/browser/notifications/notification.h"

+#include "chrome/browser/notifications/notification_common.h"

#include "chrome/browser/notifications/notification_display_service_factory.h"

#include "chrome/browser/notifications/persistent_notification_delegate.h"

#include "chrome/browser/notifications/platform_notification_service_impl.h"

@@ -217,8 +218,7 @@ bool NotificationPlatformBridgeMac::SupportsNotificationCenter() const {

PlatformNotificationServiceImpl::GetInstance()

->ProcessPersistentNotificationOperation(

- static_cast<PlatformNotificationServiceImpl::NotificationOperation>(

- operation.intValue),

+ static_cast<NotificationCommon::Operation>(operation.intValue),

profileId, [isIncognito boolValue], origin, persistentId,

buttonIndex.intValue);

}