chrome/browser/notifications/notification_platform_bridge_android.cc - Issue 2095223002: Refactor notification operation functionality out of PNS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/notification_platform_bridge_android.cc

Issue 2095223002: Refactor notification operation functionality out of PNS (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: remove enum suffix Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/notifications/notification_object_proxy.cc ('k') | chrome/browser/notifications/notification_platform_bridge_mac.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/notification_platform_bridge_android.cc

diff --git a/chrome/browser/notifications/notification_platform_bridge_android.cc b/chrome/browser/notifications/notification_platform_bridge_android.cc

index 91e509990ddde34705e2eff83ce245b45b137957..3e1204e64312ec893d51fcd83399659cef0d2d10 100644

--- a/chrome/browser/notifications/notification_platform_bridge_android.cc

+++ b/chrome/browser/notifications/notification_platform_bridge_android.cc

@@ -15,6 +15,7 @@

#include "base/strings/string_number_conversions.h"

#include "chrome/browser/browser_process.h"

#include "chrome/browser/notifications/notification.h"

+#include "chrome/browser/notifications/notification_common.h"

#include "chrome/browser/notifications/persistent_notification_delegate.h"

#include "chrome/browser/notifications/platform_notification_service_impl.h"

#include "chrome/browser/profiles/profile_manager.h"

@@ -105,8 +106,8 @@ void NotificationPlatformBridgeAndroid::OnNotificationClicked(

PlatformNotificationServiceImpl::GetInstance()

->ProcessPersistentNotificationOperation(

- PlatformNotificationServiceImpl::NOTIFICATION_CLICK, profile_id,

- incognito, origin, persistent_notification_id, action_index);

+ NotificationCommon::CLICK, profile_id, incognito, origin,

+ persistent_notification_id, action_index);

}

void NotificationPlatformBridgeAndroid::OnNotificationClosed(

@@ -126,8 +127,8 @@ void NotificationPlatformBridgeAndroid::OnNotificationClosed(

regenerated_notification_infos_.erase(persistent_notification_id);

PlatformNotificationServiceImpl::GetInstance()

->ProcessPersistentNotificationOperation(

- PlatformNotificationServiceImpl::NOTIFICATION_CLOSE, profile_id,

- incognito, origin, persistent_notification_id, -1);

+ NotificationCommon::CLOSE, profile_id, incognito, origin,

+ persistent_notification_id, -1);

}

void NotificationPlatformBridgeAndroid::Display(