Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1629)

Unified Diff: chrome/browser/notifications/notification_display_service.h

Issue 2093953002: Introduce a new API to handle native notification clicks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: initial review Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/notifications/notification_display_service.h
diff --git a/chrome/browser/notifications/notification_display_service.h b/chrome/browser/notifications/notification_display_service.h
index 6bbd645747f3eecca310333ac705dab6008ad777..84a446b49bda5e4ce71ae921c1077347240325fd 100644
--- a/chrome/browser/notifications/notification_display_service.h
+++ b/chrome/browser/notifications/notification_display_service.h
@@ -8,6 +8,7 @@
#include <set>
#include <string>
#include "base/macros.h"
Peter Beverloo 2016/07/05 14:25:34 nit: blank line above here
Miguel Garcia 2016/07/05 17:12:52 Done.
+#include "chrome/browser/notifications/notification_common.h"
#include "components/keyed_service/core/keyed_service.h"
class Notification;
@@ -27,11 +28,13 @@ class NotificationDisplayService : public KeyedService {
~NotificationDisplayService() override {}
// Displays the |notification| identified by |notification_id|.
- virtual void Display(const std::string& notification_id,
+ virtual void Display(NotificationCommon::Type notification_type,
+ const std::string& notification_id,
const Notification& notification) = 0;
// Closes the notification identified by |notification_id|.
- virtual void Close(const std::string& notification_id) = 0;
+ virtual void Close(NotificationCommon::Type notification_type,
+ const std::string& notification_id) = 0;
// Returns whether the implementation can retrieve a list of currently visible
// notifications and stores them in |*notification_ids| when possible.

Powered by Google App Engine
This is Rietveld 408576698