Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Side by Side Diff: chrome/browser/notifications/notification_display_service.h

Issue 2093953002: Introduce a new API to handle native notification clicks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: initial review Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_NOTIFICATIONS_NOTIFICATION_DISPLAY_SERVICE_H_ 5 #ifndef CHROME_BROWSER_NOTIFICATIONS_NOTIFICATION_DISPLAY_SERVICE_H_
6 #define CHROME_BROWSER_NOTIFICATIONS_NOTIFICATION_DISPLAY_SERVICE_H_ 6 #define CHROME_BROWSER_NOTIFICATIONS_NOTIFICATION_DISPLAY_SERVICE_H_
7 7
8 #include <set> 8 #include <set>
9 #include <string> 9 #include <string>
10 #include "base/macros.h" 10 #include "base/macros.h"
Peter Beverloo 2016/07/05 14:25:34 nit: blank line above here
Miguel Garcia 2016/07/05 17:12:52 Done.
11 #include "chrome/browser/notifications/notification_common.h"
11 #include "components/keyed_service/core/keyed_service.h" 12 #include "components/keyed_service/core/keyed_service.h"
12 13
13 class Notification; 14 class Notification;
14 class NotificationPlatformBridge; 15 class NotificationPlatformBridge;
15 class Profile; 16 class Profile;
16 17
17 // Profile-bound service that enables notifications to be displayed and 18 // Profile-bound service that enables notifications to be displayed and
18 // interacted with on the user's screen, orthogonal of whether this 19 // interacted with on the user's screen, orthogonal of whether this
19 // functionality is provided by the browser or by the operating system. An 20 // functionality is provided by the browser or by the operating system. An
20 // instance can be retrieved through the NotificationDisplayServiceFactory. 21 // instance can be retrieved through the NotificationDisplayServiceFactory.
21 // 22 //
22 // TODO(peter): Add a NotificationHandler mechanism for registering listeners. 23 // TODO(peter): Add a NotificationHandler mechanism for registering listeners.
23 // TODO(miguelg): Remove the SupportsNotificationCenter method. 24 // TODO(miguelg): Remove the SupportsNotificationCenter method.
24 class NotificationDisplayService : public KeyedService { 25 class NotificationDisplayService : public KeyedService {
25 public: 26 public:
26 NotificationDisplayService() {} 27 NotificationDisplayService() {}
27 ~NotificationDisplayService() override {} 28 ~NotificationDisplayService() override {}
28 29
29 // Displays the |notification| identified by |notification_id|. 30 // Displays the |notification| identified by |notification_id|.
30 virtual void Display(const std::string& notification_id, 31 virtual void Display(NotificationCommon::Type notification_type,
32 const std::string& notification_id,
31 const Notification& notification) = 0; 33 const Notification& notification) = 0;
32 34
33 // Closes the notification identified by |notification_id|. 35 // Closes the notification identified by |notification_id|.
34 virtual void Close(const std::string& notification_id) = 0; 36 virtual void Close(NotificationCommon::Type notification_type,
37 const std::string& notification_id) = 0;
35 38
36 // Returns whether the implementation can retrieve a list of currently visible 39 // Returns whether the implementation can retrieve a list of currently visible
37 // notifications and stores them in |*notification_ids| when possible. 40 // notifications and stores them in |*notification_ids| when possible.
38 virtual bool GetDisplayed(std::set<std::string>* notifications) const = 0; 41 virtual bool GetDisplayed(std::set<std::string>* notifications) const = 0;
39 42
40 // Temporary method while we finish the refactor. Returns whether there is 43 // Temporary method while we finish the refactor. Returns whether there is
41 // a native notification center backing up notifications. 44 // a native notification center backing up notifications.
42 virtual bool SupportsNotificationCenter() const = 0; 45 virtual bool SupportsNotificationCenter() const = 0;
43 46
44 private: 47 private:
45 DISALLOW_COPY_AND_ASSIGN(NotificationDisplayService); 48 DISALLOW_COPY_AND_ASSIGN(NotificationDisplayService);
46 }; 49 };
47 50
48 #endif // CHROME_BROWSER_NOTIFICATIONS_NOTIFICATION_DISPLAY_SERVICE_H_ 51 #endif // CHROME_BROWSER_NOTIFICATIONS_NOTIFICATION_DISPLAY_SERVICE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698