Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2827)

Unified Diff: chrome/browser/ui/cocoa/notifications/notification_response_builder_mac_unittest.mm

Issue 2093953002: Introduce a new API to handle native notification clicks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nits Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/notifications/notification_response_builder_mac_unittest.mm
diff --git a/chrome/browser/ui/cocoa/notifications/notification_response_builder_mac_unittest.mm b/chrome/browser/ui/cocoa/notifications/notification_response_builder_mac_unittest.mm
index 0d4a78dc01c205504e96cbdf782fefdb6fb64cdf..9c81d5aabe6f9069a5de73d4139c01933c410ee3 100644
--- a/chrome/browser/ui/cocoa/notifications/notification_response_builder_mac_unittest.mm
+++ b/chrome/browser/ui/cocoa/notifications/notification_response_builder_mac_unittest.mm
@@ -5,6 +5,7 @@
#import <AppKit/AppKit.h>
#include "base/mac/scoped_nsobject.h"
+#include "chrome/browser/notifications/notification_common.h"
#include "chrome/browser/ui/cocoa/notifications/notification_builder_mac.h"
#include "chrome/browser/ui/cocoa/notifications/notification_constants_mac.h"
#include "chrome/browser/ui/cocoa/notifications/notification_response_builder_mac.h"
@@ -21,6 +22,9 @@ TEST(NotificationResponseBuilderMacTest, TestNotificationClick) {
[builder setNotificationId:@"notificationId"];
[builder setProfileId:@"profileId"];
[builder setIncognito:false];
+ [builder
+ setNotificationType:[NSNumber
+ numberWithInt:NotificationCommon::PERSISTENT]];
NSUserNotification* notification = [builder buildUserNotification];
NSDictionary* response =
@@ -45,6 +49,9 @@ TEST(NotificationResponseBuilderMacTest, TestNotificationSettingsClick) {
[builder setNotificationId:@"notificationId"];
[builder setProfileId:@"profileId"];
[builder setIncognito:false];
+ [builder
+ setNotificationType:[NSNumber
+ numberWithInt:NotificationCommon::PERSISTENT]];
NSUserNotification* notification = [builder buildUserNotification];
@@ -78,6 +85,9 @@ TEST(NotificationResponseBuilderMacTest, TestNotificationOneActionClick) {
[builder setNotificationId:@"notificationId"];
[builder setProfileId:@"profileId"];
[builder setIncognito:false];
+ [builder
+ setNotificationType:[NSNumber
+ numberWithInt:NotificationCommon::PERSISTENT]];
NSUserNotification* notification = [builder buildUserNotification];
@@ -113,6 +123,9 @@ TEST(NotificationResponseBuilderMacTest, TestNotificationTwoActionClick) {
[builder setNotificationId:@"notificationId"];
[builder setProfileId:@"profileId"];
[builder setIncognito:false];
+ [builder
+ setNotificationType:[NSNumber
+ numberWithInt:NotificationCommon::PERSISTENT]];
NSUserNotification* notification = [builder buildUserNotification];
@@ -150,6 +163,9 @@ TEST(NotificationResponseBuilderMacTest,
[builder setNotificationId:@"notificationId"];
[builder setProfileId:@"profileId"];
[builder setIncognito:false];
+ [builder
+ setNotificationType:[NSNumber
+ numberWithInt:NotificationCommon::PERSISTENT]];
NSUserNotification* notification = [builder buildUserNotification];
« no previous file with comments | « chrome/browser/ui/cocoa/notifications/notification_response_builder_mac.mm ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698