chrome/browser/ui/cocoa/notifications/notification_response_builder_mac.mm - Issue 2093953002: Introduce a new API to handle native notification clicks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/notifications/notification_response_builder_mac.mm

Issue 2093953002: Introduce a new API to handle native notification clicks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nits Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/notifications/notification_constants_mac.mm ('k') | chrome/browser/ui/cocoa/notifications/notification_response_builder_mac_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/notifications/notification_response_builder_mac.mm

diff --git a/chrome/browser/ui/cocoa/notifications/notification_response_builder_mac.mm b/chrome/browser/ui/cocoa/notifications/notification_response_builder_mac.mm

index 1e78261b9fbf769cb44618815aa1f7753f5d9b47..c773dc5404d75f2cd370dd6b28e8bc1302665550 100644

--- a/chrome/browser/ui/cocoa/notifications/notification_response_builder_mac.mm

+++ b/chrome/browser/ui/cocoa/notifications/notification_response_builder_mac.mm

@@ -43,6 +43,8 @@ enum NotificationOperation {

objectForKey:notification_constants::kNotificationIncognito]);

NSNumber* incognito = [[notification userInfo]

objectForKey:notification_constants::kNotificationIncognito];

+ NSNumber* notificationType = [[notification userInfo]

+ objectForKey:notification_constants::kNotificationType];

// Initialize operation and button index for the case where the

// notification itself was clicked.

@@ -88,8 +90,9 @@ enum NotificationOperation {

notification_constants::kNotificationId : notificationId,

notification_constants::kNotificationProfileId : profileId,

notification_constants::kNotificationIncognito : incognito,

- notification_constants::kNotificationOperation :

- [NSNumber numberWithInt:operation],

+ notification_constants::kNotificationType : notificationType,

+ notification_constants::

+ kNotificationOperation : [NSNumber numberWithInt:operation],

notification_constants::

kNotificationButtonIndex : [NSNumber numberWithInt:buttonIndex],

};