Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2932)

Unified Diff: chrome/browser/ui/cocoa/notifications/notification_builder_mac_unittest.mm

Issue 2093953002: Introduce a new API to handle native notification clicks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nits Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/notifications/notification_builder_mac_unittest.mm
diff --git a/chrome/browser/ui/cocoa/notifications/notification_builder_mac_unittest.mm b/chrome/browser/ui/cocoa/notifications/notification_builder_mac_unittest.mm
index 9baa9f55b9bd74e2a3c1f2cfbd4ba360e8020136..63edf3456f25ede9a7ca7d569a84025c50a38988 100644
--- a/chrome/browser/ui/cocoa/notifications/notification_builder_mac_unittest.mm
+++ b/chrome/browser/ui/cocoa/notifications/notification_builder_mac_unittest.mm
@@ -7,6 +7,7 @@
#include "base/mac/foundation_util.h"
#include "base/mac/scoped_nsobject.h"
#include "base/strings/sys_string_conversions.h"
+#include "chrome/browser/notifications/notification_common.h"
#include "chrome/browser/ui/cocoa/notifications/notification_builder_mac.h"
#include "chrome/browser/ui/cocoa/notifications/notification_constants_mac.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -22,6 +23,8 @@ TEST(NotificationBuilderMacTest, TestNotificationNoButtons) {
[builder setNotificationId:@"notificationId"];
[builder setProfileId:@"profileId"];
[builder setIncognito:false];
+ [builder setNotificationType:
+ [NSNumber numberWithInt:NotificationCommon::NON_PERSISTENT]];
NSUserNotification* notification = [builder buildUserNotification];
EXPECT_EQ("Title", base::SysNSStringToUTF8([notification title]));
@@ -47,6 +50,9 @@ TEST(NotificationBuilderMacTest, TestNotificationOneButton) {
[builder setNotificationId:@"notificationId"];
[builder setProfileId:@"profileId"];
[builder setIncognito:false];
+ [builder
+ setNotificationType:[NSNumber
+ numberWithInt:NotificationCommon::PERSISTENT]];
NSUserNotification* notification = [builder buildUserNotification];
@@ -78,6 +84,9 @@ TEST(NotificationBuilderMacTest, TestNotificationTwoButtons) {
[builder setNotificationId:@"notificationId"];
[builder setProfileId:@"profileId"];
[builder setIncognito:false];
+ [builder
+ setNotificationType:[NSNumber
+ numberWithInt:NotificationCommon::PERSISTENT]];
NSUserNotification* notification = [builder buildUserNotification];
@@ -108,6 +117,9 @@ TEST(NotificationBuilderMacTest, TestUserInfo) {
[builder setOrigin:@"https://www.miguel.com"];
[builder setNotificationId:@"Notification1"];
[builder setIncognito:true];
+ [builder
+ setNotificationType:[NSNumber
+ numberWithInt:NotificationCommon::PERSISTENT]];
NSUserNotification* notification = [builder buildUserNotification];
EXPECT_EQ("Title", base::SysNSStringToUTF8([notification title]));
@@ -138,6 +150,10 @@ TEST(NotificationBuilderMacTest, TestBuildDictionary) {
[sourceBuilder setNotificationId:@"notificationId"];
[sourceBuilder setProfileId:@"profileId"];
[sourceBuilder setIncognito:false];
+ [sourceBuilder
+ setNotificationType:
+ [NSNumber numberWithInt:NotificationCommon::NON_PERSISTENT]];
+
notificationData = [sourceBuilder buildDictionary];
}
base::scoped_nsobject<NotificationBuilder> finalBuilder(

Powered by Google App Engine
This is Rietveld 408576698