Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2749)

Unified Diff: chrome/browser/ui/cocoa/notifications/notification_builder_mac.mm

Issue 2093953002: Introduce a new API to handle native notification clicks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nits Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/notifications/notification_builder_mac.mm
diff --git a/chrome/browser/ui/cocoa/notifications/notification_builder_mac.mm b/chrome/browser/ui/cocoa/notifications/notification_builder_mac.mm
index 1d64752e2086d3195da3525071d166b0d3c086da..6bd715d014c4ea9f299e191168c25cf95fabd5e6 100644
--- a/chrome/browser/ui/cocoa/notifications/notification_builder_mac.mm
+++ b/chrome/browser/ui/cocoa/notifications/notification_builder_mac.mm
@@ -114,6 +114,11 @@ NSString* const kNotificationSettingsButtonTag = @"settingsButton";
forKey:notification_constants::kNotificationIncognito];
}
+- (void)setNotificationType:(NSNumber*)notificationType {
+ [notificationData_ setObject:notificationType
+ forKey:notification_constants::kNotificationType];
+}
+
- (NSUserNotification*)buildUserNotification {
base::scoped_nsobject<NSUserNotification> toast(
[[NSUserNotification alloc] init]);
@@ -205,12 +210,15 @@ NSString* const kNotificationSettingsButtonTag = @"settingsButton";
objectForKey:notification_constants::kNotificationIncognito]);
NSNumber* incognito = [notificationData_
objectForKey:notification_constants::kNotificationIncognito];
+ NSNumber* type = [notificationData_
+ objectForKey:notification_constants::kNotificationType];
toast.get().userInfo = @{
notification_constants::kNotificationOrigin : origin,
notification_constants::kNotificationId : notificationId,
notification_constants::kNotificationProfileId : profileId,
notification_constants::kNotificationIncognito : incognito,
+ notification_constants::kNotificationType : type,
};
return toast.autorelease();

Powered by Google App Engine
This is Rietveld 408576698