chrome/browser/notifications/stub_notification_platform_bridge.h - Issue 2093953002: Introduce a new API to handle native notification clicks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/stub_notification_platform_bridge.h

Issue 2093953002: Introduce a new API to handle native notification clicks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nits Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/notifications/platform_notification_service_impl.cc ('k') | chrome/browser/notifications/stub_notification_platform_bridge.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/stub_notification_platform_bridge.h

diff --git a/chrome/browser/notifications/stub_notification_platform_bridge.h b/chrome/browser/notifications/stub_notification_platform_bridge.h

index 368c502f905b5ef6f8e6362ce76c561553ec8acf..49d8cd454229cc4ac0f202e4126d148553474f65 100644

--- a/chrome/browser/notifications/stub_notification_platform_bridge.h

+++ b/chrome/browser/notifications/stub_notification_platform_bridge.h

@@ -10,6 +10,7 @@

#include "base/macros.h"

#include "chrome/browser/notifications/notification.h"

+#include "chrome/browser/notifications/notification_common.h"

#include "chrome/browser/notifications/notification_platform_bridge.h"

// Implementation of NotificationPlatformBridge used for tests.

@@ -22,7 +23,8 @@ class StubNotificationPlatformBridge : public NotificationPlatformBridge {

Notification GetNotificationAt(std::string profile_id, size_t index);

// NotificationPlatformBridge implementation.

- void Display(const std::string& notification_id,

+ void Display(NotificationCommon::Type notification_type,

+ const std::string& notification_id,

const std::string& profile_id,

bool incognito,

const Notification& notification) override;