chrome/browser/notifications/stub_notification_platform_bridge.cc - Issue 2093953002: Introduce a new API to handle native notification clicks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/stub_notification_platform_bridge.cc

Issue 2093953002: Introduce a new API to handle native notification clicks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nits Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/notifications/stub_notification_platform_bridge.h ('k') | chrome/browser/ui/cocoa/notifications/notification_builder_mac.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/stub_notification_platform_bridge.cc

diff --git a/chrome/browser/notifications/stub_notification_platform_bridge.cc b/chrome/browser/notifications/stub_notification_platform_bridge.cc

index 257a5ec3729c699103101e321f8bb866169dca20..78c21c6184ca890bb458e0c0f1391495b2ce0044 100644

--- a/chrome/browser/notifications/stub_notification_platform_bridge.cc

+++ b/chrome/browser/notifications/stub_notification_platform_bridge.cc

@@ -18,10 +18,12 @@ Notification StubNotificationPlatformBridge::GetNotificationAt(

return notifications_[profile_id][index];

}

-void StubNotificationPlatformBridge::Display(const std::string& notification_id,

- const std::string& profile_id,

- bool incognito,

- const Notification& notification) {

+void StubNotificationPlatformBridge::Display(

+ NotificationCommon::Type notification_type,

+ const std::string& notification_id,

+ const std::string& profile_id,

+ bool incognito,

+ const Notification& notification) {

notifications_[profile_id].push_back(notification);

}