Remove queryUsageAndQuota API

Remove queryUsageAndQuota API

This is gone in Chrome 34.  It's breaking the dart2js analyze_api test.

TBR'ing to get the bots green.

TBR=blois@google.com

Committed: https://code.google.com/p/dart/source/detail?r=34376

[vsm, 2014-03-25 18:06:36]

Committed patchset #1 manually as r34376 (presubmit successful).

[blois, 2014-03-25 19:06:01]

https://chromiumcodereview.appspot.com/208743003/diff/1/sdk/lib/html/dart2js/...
File sdk/lib/html/dart2js/html_dart2js.dart (left):

https://chromiumcodereview.appspot.com/208743003/diff/1/sdk/lib/html/dart2js/...
sdk/lib/html/dart2js/html_dart2js.dart:24468: -  Future<StorageInfoUsage>
queryUsageAndQuota(int storageType) {
I'm pretty sure that people are using this API right now. The replacement API
uses Promises and isn't being generated.

http://www.w3.org/TR/quota-api/#idl-def-StorageQuota

What needs to be done to get this working?

[vsm, 2014-03-25 19:50:11]

https://chromiumcodereview.appspot.com/208743003/diff/1/sdk/lib/html/dart2js/...
File sdk/lib/html/dart2js/html_dart2js.dart (left):

https://chromiumcodereview.appspot.com/208743003/diff/1/sdk/lib/html/dart2js/...
sdk/lib/html/dart2js/html_dart2js.dart:24468: -  Future<StorageInfoUsage>
queryUsageAndQuota(int storageType) {
StorageInfo is the type changed here, not StorageQuota.  Here are the IDL
changes.  It appears that usage and quota are just attributes now:

 ] interface StorageInfo {
-    const unsigned short TEMPORARY = 0;
-    const unsigned short PERSISTENT = 1;
-
-    [CallWith=ExecutionContext] void queryUsageAndQuota(unsigned short
storageType, optional StorageUsageCallback usageCallback, optional
StorageErrorCallba
-    [CallWith=ExecutionContext] void requestQuota(unsigned short storageType,
unsigned long long newQuotaInBytes, optional StorageQuotaCallback quotaCallbac
+    readonly attribute unsigned long long usage;
+    readonly attribute unsigned long long quota;
 };


On 2014/03/25 19:06:02, blois wrote:
> I'm pretty sure that people are using this API right now. The replacement API
> uses Promises and isn't being generated.
> 
> http://www.w3.org/TR/quota-api/#idl-def-StorageQuota
> 
> What needs to be done to get this working?

[blois, 2014-03-25 21:42:01]

https://chromiumcodereview.appspot.com/208743003/diff/1/sdk/lib/html/dart2js/...
File sdk/lib/html/dart2js/html_dart2js.dart (left):

https://chromiumcodereview.appspot.com/208743003/diff/1/sdk/lib/html/dart2js/...
sdk/lib/html/dart2js/html_dart2js.dart:24468: -  Future<StorageInfoUsage>
queryUsageAndQuota(int storageType) {
On 2014/03/25 19:50:11, vsm wrote:
> StorageInfo is the type changed here, not StorageQuota.  Here are the IDL
> changes.  It appears that usage and quota are just attributes now:
> 
>  ] interface StorageInfo {
> -    const unsigned short TEMPORARY = 0;
> -    const unsigned short PERSISTENT = 1;
> -
> -    [CallWith=ExecutionContext] void queryUsageAndQuota(unsigned short
> storageType, optional StorageUsageCallback usageCallback, optional
> StorageErrorCallba
> -    [CallWith=ExecutionContext] void requestQuota(unsigned short storageType,
> unsigned long long newQuotaInBytes, optional StorageQuotaCallback quotaCallbac
> +    readonly attribute unsigned long long usage;
> +    readonly attribute unsigned long long quota;
>  };
> 
> 
> On 2014/03/25 19:06:02, blois wrote:
> > I'm pretty sure that people are using this API right now. The replacement
API
> > uses Promises and isn't being generated.
> > 
> > http://www.w3.org/TR/quota-api/#idl-def-StorageQuota
> > 
> > What needs to be done to get this working?
> 
The API to query the quota changed from StorageInfo.queryUsageAndQuota to
StorageQuota.queryInfo, which is not exposed because it uses promises.

As it stands now, there's no way to get a StorageInfo object, or to request
additional persistent quota.