Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 20860003: Remove hyphenation code from Chromium. (Closed)

Created:
7 years, 5 months ago by tony
Modified:
7 years, 4 months ago
Reviewers:
jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch_chromium.org, ojan
Visibility:
Public.

Description

Remove hyphenation code from Chromium. The feature is being removed because it is incomplete and no one is working on it right now. TBR for third_party. BUG=107111 TBR=darin Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215327

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -68911 lines) Patch
M chrome/browser/chrome_content_browser_client.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 1 chunk +0 lines, -6 lines 0 comments Download
D content/browser/hyphenator/hyphenator_message_filter.h View 1 1 chunk +0 lines, -75 lines 0 comments Download
D content/browser/hyphenator/hyphenator_message_filter.cc View 1 1 chunk +0 lines, -120 lines 0 comments Download
D content/browser/hyphenator/hyphenator_message_filter_unittest.cc View 1 1 chunk +0 lines, -154 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 chunks +0 lines, -2 lines 0 comments Download
M content/common/content_message_generator.h View 1 1 chunk +0 lines, -1 line 0 comments Download
D content/common/hyphenator_messages.h View 1 1 chunk +0 lines, -24 lines 0 comments Download
M content/content_browser.gypi View 1 1 chunk +0 lines, -2 lines 0 comments Download
M content/content_renderer.gypi View 1 2 chunks +0 lines, -3 lines 0 comments Download
M content/content_tests.gypi View 1 2 chunks +0 lines, -2 lines 0 comments Download
M content/content_unittests.isolate View 1 1 chunk +0 lines, -3 lines 0 comments Download
M content/public/browser/content_browser_client.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M content/public/browser/content_browser_client.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M content/public/renderer/content_renderer_client.h View 1 2 chunks +0 lines, -5 lines 0 comments Download
M content/public/renderer/content_renderer_client.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
D content/renderer/hyphenator/hyphenator.h View 1 1 chunk +0 lines, -74 lines 0 comments Download
D content/renderer/hyphenator/hyphenator.cc View 1 1 chunk +0 lines, -270 lines 0 comments Download
D content/renderer/hyphenator/hyphenator_unittest.cc View 1 1 chunk +0 lines, -191 lines 0 comments Download
M content/renderer/renderer_webkitplatformsupport_impl.h View 1 2 chunks +0 lines, -4 lines 0 comments Download
M content/renderer/renderer_webkitplatformsupport_impl.cc View 1 6 chunks +0 lines, -65 lines 0 comments Download
M content/shell/common/shell_messages.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M content/shell/renderer/shell_content_renderer_client.h View 1 4 chunks +0 lines, -8 lines 0 comments Download
M content/shell/renderer/shell_content_renderer_client.cc View 1 3 chunks +0 lines, -19 lines 0 comments Download
M content/shell/renderer/shell_render_process_observer.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/shell/renderer/shell_render_process_observer.cc View 1 2 chunks +0 lines, -8 lines 0 comments Download
M content/shell/shell_content_browser_client.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M content/shell/shell_content_browser_client.cc View 1 2 chunks +1 line, -18 lines 0 comments Download
D third_party/hyphen/AUTHORS View 1 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/hyphen/COPYING View 1 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/hyphen/COPYING.LGPL View 1 1 chunk +0 lines, -515 lines 0 comments Download
D third_party/hyphen/COPYING.MPL View 1 1 chunk +0 lines, -470 lines 0 comments Download
D third_party/hyphen/ChangeLog View 1 1 chunk +0 lines, -184 lines 0 comments Download
D third_party/hyphen/INSTALL View 1 1 chunk +0 lines, -229 lines 0 comments Download
D third_party/hyphen/Makefile.am View 1 1 chunk +0 lines, -38 lines 0 comments Download
D third_party/hyphen/Makefile.in View 1 1 chunk +0 lines, -956 lines 0 comments Download
D third_party/hyphen/NEWS View 1 1 chunk +0 lines, -55 lines 0 comments Download
D third_party/hyphen/README View 1 1 chunk +0 lines, -127 lines 0 comments Download
D third_party/hyphen/README.chromium View 1 1 chunk +0 lines, -15 lines 0 comments Download
D third_party/hyphen/README.compound View 1 1 chunk +0 lines, -57 lines 0 comments Download
D third_party/hyphen/README.hyphen View 1 1 chunk +0 lines, -108 lines 0 comments Download
D third_party/hyphen/README.nonstandard View 1 1 chunk +0 lines, -122 lines 0 comments Download
D third_party/hyphen/README_hyph_en_US.txt View 1 1 chunk +0 lines, -53 lines 0 comments Download
D third_party/hyphen/THANKS View 1 1 chunk +0 lines, -15 lines 0 comments Download
D third_party/hyphen/TODO View 1 1 chunk +0 lines, -3 lines 0 comments Download
D third_party/hyphen/aclocal.m4 View 1 1 chunk +0 lines, -8988 lines 0 comments Download
D third_party/hyphen/checkme.lst View 1 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/hyphen/config.guess View 1 1 chunk +0 lines, -1516 lines 0 comments Download
D third_party/hyphen/config.sub View 1 1 chunk +0 lines, -1626 lines 0 comments Download
D third_party/hyphen/configure View 1 1 chunk +0 lines, -12633 lines 0 comments Download
D third_party/hyphen/configure.in View 1 1 chunk +0 lines, -10 lines 0 comments Download
D third_party/hyphen/depcomp View 1 1 chunk +0 lines, -584 lines 0 comments Download
D third_party/hyphen/doc/Makefile.am View 1 1 chunk +0 lines, -1 line 0 comments Download
D third_party/hyphen/doc/Makefile.in View 1 1 chunk +0 lines, -346 lines 0 comments Download
D third_party/hyphen/doc/tb87nemeth.pdf View 1 0 chunks +-1 lines, --1 lines 0 comments Download
D third_party/hyphen/example.c View 1 1 chunk +0 lines, -239 lines 0 comments Download
D third_party/hyphen/google.patch View 1 1 chunk +0 lines, -69 lines 0 comments Download
D third_party/hyphen/hnjalloc.h View 1 1 chunk +0 lines, -46 lines 0 comments Download
D third_party/hyphen/hnjalloc.c View 1 1 chunk +0 lines, -72 lines 0 comments Download
D third_party/hyphen/hyph_en_US.dic View 1 1 chunk +0 lines, -11225 lines 0 comments Download
D third_party/hyphen/hyphen.h View 1 1 chunk +0 lines, -173 lines 0 comments Download
D third_party/hyphen/hyphen.c View 1 1 chunk +0 lines, -1084 lines 0 comments Download
D third_party/hyphen/hyphen.gyp View 1 1 chunk +0 lines, -31 lines 0 comments Download
D third_party/hyphen/hyphen.patch View 1 1 chunk +0 lines, -45 lines 0 comments Download
D third_party/hyphen/hyphen.tex View 1 1 chunk +0 lines, -4469 lines 0 comments Download
D third_party/hyphen/install-sh View 1 1 chunk +0 lines, -507 lines 0 comments Download
D third_party/hyphen/lig.awk View 1 1 chunk +0 lines, -42 lines 0 comments Download
D third_party/hyphen/ligpatch.txt View 1 1 chunk +0 lines, -62 lines 0 comments Download
D third_party/hyphen/ltmain.sh View 1 1 chunk +0 lines, -8745 lines 0 comments Download
D third_party/hyphen/missing View 1 1 chunk +0 lines, -367 lines 0 comments Download
D third_party/hyphen/ooopatch.sed View 1 1 chunk +0 lines, -117 lines 0 comments Download
D third_party/hyphen/substrings.c View 1 1 chunk +0 lines, -304 lines 0 comments Download
D third_party/hyphen/substrings.pl View 1 1 chunk +0 lines, -203 lines 0 comments Download
D third_party/hyphen/tbhyphext.sh View 1 1 chunk +0 lines, -42 lines 0 comments Download
D third_party/hyphen/tbhyphext.tex View 1 1 chunk +0 lines, -1047 lines 0 comments Download
D third_party/hyphen/tests/Makefile.am View 1 1 chunk +0 lines, -113 lines 0 comments Download
D third_party/hyphen/tests/Makefile.in View 1 1 chunk +0 lines, -555 lines 0 comments Download
D third_party/hyphen/tests/alt.hyph View 1 1 chunk +0 lines, -1 line 0 comments Download
D third_party/hyphen/tests/alt.pat View 1 Binary file 0 comments Download
D third_party/hyphen/tests/alt.test View 1 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/hyphen/tests/alt.word View 1 1 chunk +0 lines, -1 line 0 comments Download
D third_party/hyphen/tests/alt2.hyph View 1 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/hyphen/tests/alt2.pat View 1 Binary file 0 comments Download
D third_party/hyphen/tests/alt2.test View 1 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/hyphen/tests/alt2.word View 1 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/hyphen/tests/alt3.hyph View 1 1 chunk +0 lines, -3 lines 0 comments Download
D third_party/hyphen/tests/alt3.pat View 1 Binary file 0 comments Download
D third_party/hyphen/tests/alt3.test View 1 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/hyphen/tests/alt3.word View 1 1 chunk +0 lines, -3 lines 0 comments Download
D third_party/hyphen/tests/alt4.hyph View 1 1 chunk +0 lines, -1 line 0 comments Download
D third_party/hyphen/tests/alt4.pat View 1 Binary file 0 comments Download
D third_party/hyphen/tests/alt4.test View 1 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/hyphen/tests/alt4.word View 1 1 chunk +0 lines, -1 line 0 comments Download
D third_party/hyphen/tests/alt5.hyph View 1 1 chunk +0 lines, -1 line 0 comments Download
D third_party/hyphen/tests/alt5.pat View 1 Binary file 0 comments Download
D third_party/hyphen/tests/alt5.test View 1 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/hyphen/tests/alt5.word View 1 1 chunk +0 lines, -1 line 0 comments Download
D third_party/hyphen/tests/alt6.hyph View 1 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/hyphen/tests/alt6.pat View 1 Binary file 0 comments Download
D third_party/hyphen/tests/alt6.test View 1 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/hyphen/tests/alt6.word View 1 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/hyphen/tests/base.hyph View 1 1 chunk +0 lines, -4543 lines 0 comments Download
D third_party/hyphen/tests/base.pat View 1 Binary file 0 comments Download
D third_party/hyphen/tests/base.test View 1 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/hyphen/tests/base.word View 1 1 chunk +0 lines, -4543 lines 0 comments Download
D third_party/hyphen/tests/basealt.hyph View 1 1 chunk +0 lines, -8 lines 0 comments Download
D third_party/hyphen/tests/basealt.pat View 1 Binary file 0 comments Download
D third_party/hyphen/tests/basealt.test View 1 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/hyphen/tests/basealt.word View 1 1 chunk +0 lines, -8 lines 0 comments Download
D third_party/hyphen/tests/basealt2.hyph View 1 1 chunk +0 lines, -8 lines 0 comments Download
D third_party/hyphen/tests/basealt2.pat View 1 Binary file 0 comments Download
D third_party/hyphen/tests/basealt2.test View 1 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/hyphen/tests/basealt2.word View 1 1 chunk +0 lines, -8 lines 0 comments Download
D third_party/hyphen/tests/compound.hyph View 1 1 chunk +0 lines, -1 line 0 comments Download
D third_party/hyphen/tests/compound.pat View 1 Binary file 0 comments Download
D third_party/hyphen/tests/compound.test View 1 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/hyphen/tests/compound.word View 1 1 chunk +0 lines, -1 line 0 comments Download
D third_party/hyphen/tests/compound2.hyph View 1 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/hyphen/tests/compound2.pat View 1 Binary file 0 comments Download
D third_party/hyphen/tests/compound2.test View 1 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/hyphen/tests/compound2.word View 1 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/hyphen/tests/compound3.hyph View 1 1 chunk +0 lines, -1 line 0 comments Download
D third_party/hyphen/tests/compound3.pat View 1 Binary file 0 comments Download
D third_party/hyphen/tests/compound3.test View 1 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/hyphen/tests/compound3.word View 1 1 chunk +0 lines, -1 line 0 comments Download
D third_party/hyphen/tests/compound4.hyph View 1 1 chunk +0 lines, -1 line 0 comments Download
D third_party/hyphen/tests/compound4.pat View 1 Binary file 0 comments Download
D third_party/hyphen/tests/compound4.test View 1 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/hyphen/tests/compound4.word View 1 1 chunk +0 lines, -1 line 0 comments Download
D third_party/hyphen/tests/conv.dic View 1 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/hyphen/tests/conv.hyph View 1 1 chunk +0 lines, -14 lines 0 comments Download
D third_party/hyphen/tests/conv.pat View 1 Binary file 0 comments Download
D third_party/hyphen/tests/conv.test View 1 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/hyphen/tests/conv.word View 1 1 chunk +0 lines, -14 lines 0 comments Download
D third_party/hyphen/tests/lhmin.hyph View 1 1 chunk +0 lines, -1 line 0 comments Download
D third_party/hyphen/tests/lhmin.pat View 1 Binary file 0 comments Download
D third_party/hyphen/tests/lhmin.test View 1 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/hyphen/tests/lhmin.word View 1 1 chunk +0 lines, -1 line 0 comments Download
D third_party/hyphen/tests/lig.hyph View 1 1 chunk +0 lines, -1 line 0 comments Download
D third_party/hyphen/tests/lig.pat View 1 Binary file 0 comments Download
D third_party/hyphen/tests/lig.test View 1 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/hyphen/tests/lig.word View 1 1 chunk +0 lines, -1 line 0 comments Download
D third_party/hyphen/tests/settings.hyph View 1 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/hyphen/tests/settings.pat View 1 Binary file 0 comments Download
D third_party/hyphen/tests/settings.test View 1 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/hyphen/tests/settings.word View 1 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/hyphen/tests/settings2.hyph View 1 1 chunk +0 lines, -1 line 0 comments Download
D third_party/hyphen/tests/settings2.pat View 1 Binary file 0 comments Download
D third_party/hyphen/tests/settings2.test View 1 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/hyphen/tests/settings2.word View 1 1 chunk +0 lines, -1 line 0 comments Download
D third_party/hyphen/tests/settings3.hyph View 1 1 chunk +0 lines, -1 line 0 comments Download
D third_party/hyphen/tests/settings3.pat View 1 Binary file 0 comments Download
D third_party/hyphen/tests/settings3.test View 1 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/hyphen/tests/settings3.word View 1 1 chunk +0 lines, -1 line 0 comments Download
D third_party/hyphen/tests/settings4.hyph View 1 1 chunk +0 lines, -1 line 0 comments Download
D third_party/hyphen/tests/settings4.pat View 1 Binary file 0 comments Download
D third_party/hyphen/tests/settings4.test View 1 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/hyphen/tests/settings4.word View 1 1 chunk +0 lines, -1 line 0 comments Download
D third_party/hyphen/tests/test.sh View 1 1 chunk +0 lines, -91 lines 0 comments Download
D third_party/hyphen/tests/unicode.hyph View 1 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/hyphen/tests/unicode.pat View 1 Binary file 0 comments Download
D third_party/hyphen/tests/unicode.test View 1 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/hyphen/tests/unicode.word View 1 1 chunk +0 lines, -13 lines 0 comments Download
D webkit/mocks/mock_webhyphenator.h View 1 1 chunk +0 lines, -44 lines 0 comments Download
D webkit/mocks/mock_webhyphenator.cc View 1 1 chunk +0 lines, -103 lines 0 comments Download
M webkit/support/test_webkit_platform_support.h View 1 3 chunks +0 lines, -3 lines 0 comments Download
M webkit/support/test_webkit_platform_support.cc View 1 2 chunks +0 lines, -16 lines 0 comments Download
M webkit/support/webkit_support.gypi View 1 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
tony
Most of the WebKit side was removed in http://src.chromium.org/viewvc/blink?view=revision&revision=155171 .
7 years, 4 months ago (2013-07-30 22:27:59 UTC) #1
jam
lgtm
7 years, 4 months ago (2013-07-30 23:30:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tony@chromium.org/20860003/94001
7 years, 4 months ago (2013-07-31 17:27:45 UTC) #3
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=18038
7 years, 4 months ago (2013-07-31 17:57:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tony@chromium.org/20860003/94001
7 years, 4 months ago (2013-07-31 18:03:48 UTC) #5
commit-bot: I haz the power
The commit queue went berserk retrying too often for a seemingly flaky test on builder ...
7 years, 4 months ago (2013-08-01 04:24:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tony@chromium.org/20860003/94001
7 years, 4 months ago (2013-08-02 17:29:38 UTC) #7
commit-bot: I haz the power
Change committed as 215327
7 years, 4 months ago (2013-08-02 18:39:57 UTC) #8
Kristian Monsen
7 years, 4 months ago (2013-08-02 19:50:50 UTC) #9
Message was sent while issue was closed. 
On 2013/08/02 18:39:57, I haz the power (commit-bot) wrote:
> Change committed as 215327

This breaks the license check since there is not a third_party/hyphen directory
without a license file. Can you please remove the empty directories as well?

Powered by Google App Engine
This is Rietveld 408576698