Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(63)

Issue 20856002: applyXSLTransform is too eager (Closed)

Created:
7 years ago by abarth-chromium
Modified:
7 years ago
Reviewers:
eseidel
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org
Visibility:
Public.

Description

applyXSLTransform is too eager There's nothing that stops ProcessingInstruction from applying XSL Transforms to HTML documents or from applying incompletely loaded XSL Transforms. This CL adds a couple checks to avoid these cases. The XSL Transform system is a bundle of insanity. So much of the system makes so little sense it's hard to know where to start fixing it. Eric Seidel's opinion is that we shouldn't drive the XSL transform process from style resolution. Instead, we should kick off the transform either from DOMContentLoaded or from the XSL sheet's load event. We tried a couple approaches along those lines, but we didn't finish them for this CL. Maybe we'll get that working for a future CL. R=eseidel BUG=260105 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155043

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M Source/core/dom/Document.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/ProcessingInstruction.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/dom/StyleSheetCollection.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
abarth-chromium
7 years ago (2013-07-26 23:07:06 UTC) #1
eseidel
lgtm Bleh.
7 years ago (2013-07-26 23:11:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/20856002/1
7 years ago (2013-07-26 23:12:44 UTC) #3
commit-bot: I haz the power
7 years ago (2013-07-27 02:45:47 UTC) #4
Message was sent while issue was closed.
Change committed as 155043

Powered by Google App Engine
This is Rietveld 408576698