Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Side by Side Diff: Source/core/dom/Document.cpp

Issue 20856002: applyXSLTransform is too eager (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | Source/core/dom/ProcessingInstruction.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org) 5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All r ights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All r ights reserved.
7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
8 * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved. 8 * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved.
9 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies) 9 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
10 * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved. 10 * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved.
(...skipping 3886 matching lines...) Expand 10 before | Expand all | Expand 10 after
3897 } 3897 }
3898 3898
3899 void Document::popCurrentScript() 3899 void Document::popCurrentScript()
3900 { 3900 {
3901 ASSERT(!m_currentScriptStack.isEmpty()); 3901 ASSERT(!m_currentScriptStack.isEmpty());
3902 m_currentScriptStack.removeLast(); 3902 m_currentScriptStack.removeLast();
3903 } 3903 }
3904 3904
3905 void Document::applyXSLTransform(ProcessingInstruction* pi) 3905 void Document::applyXSLTransform(ProcessingInstruction* pi)
3906 { 3906 {
3907 ASSERT(!pi->isLoading());
3907 UseCounter::count(this, UseCounter::XSLProcessingInstruction); 3908 UseCounter::count(this, UseCounter::XSLProcessingInstruction);
3908 RefPtr<XSLTProcessor> processor = XSLTProcessor::create(); 3909 RefPtr<XSLTProcessor> processor = XSLTProcessor::create();
3909 processor->setXSLStyleSheet(static_cast<XSLStyleSheet*>(pi->sheet())); 3910 processor->setXSLStyleSheet(static_cast<XSLStyleSheet*>(pi->sheet()));
3910 String resultMIMEType; 3911 String resultMIMEType;
3911 String newSource; 3912 String newSource;
3912 String resultEncoding; 3913 String resultEncoding;
3913 if (!processor->transformToString(this, resultMIMEType, newSource, resultEnc oding)) 3914 if (!processor->transformToString(this, resultMIMEType, newSource, resultEnc oding))
3914 return; 3915 return;
3915 // FIXME: If the transform failed we should probably report an error (like M ozilla does). 3916 // FIXME: If the transform failed we should probably report an error (like M ozilla does).
3916 Frame* ownerFrame = frame(); 3917 Frame* ownerFrame = frame();
(...skipping 1169 matching lines...) Expand 10 before | Expand all | Expand 10 after
5086 { 5087 {
5087 return DocumentLifecycleNotifier::create(this); 5088 return DocumentLifecycleNotifier::create(this);
5088 } 5089 }
5089 5090
5090 DocumentLifecycleNotifier* Document::lifecycleNotifier() 5091 DocumentLifecycleNotifier* Document::lifecycleNotifier()
5091 { 5092 {
5092 return static_cast<DocumentLifecycleNotifier*>(ScriptExecutionContext::lifec ycleNotifier()); 5093 return static_cast<DocumentLifecycleNotifier*>(ScriptExecutionContext::lifec ycleNotifier());
5093 } 5094 }
5094 5095
5095 } // namespace WebCore 5096 } // namespace WebCore
OLDNEW
« no previous file with comments | « no previous file | Source/core/dom/ProcessingInstruction.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698