Issue 207653002: Native entry point for spawnDomUri

Issue 207653002: Native entry point for spawnDomUri (Closed)

Created:
6 years, 9 months ago by vsm

Modified:
6 years, 9 months ago

Reviewers:
Siggi Cherem (dart-lang), siva, Jacob

CC:
reviews_dartlang.org, ricow1, Siggi Cherem (dart-lang), Lasse Reichstein Nielsen

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Native entry point for spawnDomUri R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=34337

Patch Set 2 : Update comment #

Total comments: 4

Patch Set 3 : Address commetns #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -0 lines)			Patch
	M	tools/dom/src/native_DOMImplementation.dart	View		1 chunk	+3 lines, -0 lines	0 comments	Download
	M	tools/dom/templates/html/dartium/html_dartium.darttemplate	View	1 2	1 chunk	+12 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

siva

lgtm https://chromiumcodereview.appspot.com/207653002/diff/20001/tools/dom/src/native_DOMImplementation.dart File tools/dom/src/native_DOMImplementation.dart (right): https://chromiumcodereview.appspot.com/207653002/diff/20001/tools/dom/src/native_DOMImplementation.dart#newcode111 tools/dom/src/native_DOMImplementation.dart:111: // return a Future<Isolate>. Could we open a ...

6 years, 9 months ago (2014-03-24 16:43:32 UTC) #2

Siggi Cherem (dart-lang)

thanks Vijay! https://chromiumcodereview.appspot.com/207653002/diff/20001/tools/dom/templates/html/dartium/html_dartium.darttemplate File tools/dom/templates/html/dartium/html_dartium.darttemplate (right): https://chromiumcodereview.appspot.com/207653002/diff/20001/tools/dom/templates/html/dartium/html_dartium.darttemplate#newcode129 tools/dom/templates/html/dartium/html_dartium.darttemplate:129: Future<Isolate> spawnDomUri(Uri uri, List<String> args, message) { ...

6 years, 9 months ago (2014-03-24 16:51:55 UTC) #3

vsm

https://chromiumcodereview.appspot.com/207653002/diff/20001/tools/dom/src/native_DOMImplementation.dart File tools/dom/src/native_DOMImplementation.dart (right): https://chromiumcodereview.appspot.com/207653002/diff/20001/tools/dom/src/native_DOMImplementation.dart#newcode111 tools/dom/src/native_DOMImplementation.dart:111: // return a Future<Isolate>. On 2014/03/24 16:43:32, siva wrote: ...

6 years, 9 months ago (2014-03-24 21:52:57 UTC) #4

vsm

6 years, 9 months ago (2014-03-24 21:56:47 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 manually as r34337 (presubmit successful).

Expand Messages | Collapse Messages