Issue 20706002: Fix Smi-based MathMinMax on x64, and reenable smi mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 20706002: Fix Smi-based MathMinMax on x64, and reenable smi mode. (Closed)

Created:
7 years, 5 months ago by Toon Verwaest

Modified:
7 years, 4 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Fix Smi-based MathMinMax on x64, and reenable smi mode. BUG= R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15905

Total comments: 1

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -8 lines)			Patch
M	src/hydrogen-instructions.h	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View	1 2	2 chunks	+12 lines, -3 lines	0 comments	Download
M	src/x64/lithium-x64.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	test/mjsunit/math-min-max.js	View	1	1 chunk	+15 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

Jakob Kummerow

LGTM with comment. Also, I'd really like to see a big test that tests all ...

7 years, 5 months ago (2013-07-26 11:26:13 UTC) #2

Toon Verwaest

7 years, 5 months ago (2013-07-26 12:06:28 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r15905 (presubmit successful).