Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Side by Side Diff: src/x64/lithium-x64.cc

Issue 20706002: Fix Smi-based MathMinMax on x64, and reenable smi mode. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comment Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/x64/lithium-codegen-x64.cc ('k') | test/mjsunit/math-min-max.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1544 matching lines...) Expand 10 before | Expand all | Expand 10 after
1555 ASSERT(instr->representation().IsTagged()); 1555 ASSERT(instr->representation().IsTagged());
1556 return DoArithmeticT(Token::ADD, instr); 1556 return DoArithmeticT(Token::ADD, instr);
1557 } 1557 }
1558 return NULL; 1558 return NULL;
1559 } 1559 }
1560 1560
1561 1561
1562 LInstruction* LChunkBuilder::DoMathMinMax(HMathMinMax* instr) { 1562 LInstruction* LChunkBuilder::DoMathMinMax(HMathMinMax* instr) {
1563 LOperand* left = NULL; 1563 LOperand* left = NULL;
1564 LOperand* right = NULL; 1564 LOperand* right = NULL;
1565 if (instr->representation().IsInteger32()) { 1565 if (instr->representation().IsSmiOrInteger32()) {
1566 ASSERT(instr->left()->representation().IsInteger32()); 1566 ASSERT(instr->left()->representation().Equals(instr->representation()));
1567 ASSERT(instr->right()->representation().IsInteger32()); 1567 ASSERT(instr->right()->representation().Equals(instr->representation()));
1568 left = UseRegisterAtStart(instr->BetterLeftOperand()); 1568 left = UseRegisterAtStart(instr->BetterLeftOperand());
1569 right = UseOrConstantAtStart(instr->BetterRightOperand()); 1569 right = UseOrConstantAtStart(instr->BetterRightOperand());
1570 } else { 1570 } else {
1571 ASSERT(instr->representation().IsDouble()); 1571 ASSERT(instr->representation().IsDouble());
1572 ASSERT(instr->left()->representation().IsDouble()); 1572 ASSERT(instr->left()->representation().IsDouble());
1573 ASSERT(instr->right()->representation().IsDouble()); 1573 ASSERT(instr->right()->representation().IsDouble());
1574 left = UseRegisterAtStart(instr->left()); 1574 left = UseRegisterAtStart(instr->left());
1575 right = UseRegisterAtStart(instr->right()); 1575 right = UseRegisterAtStart(instr->right());
1576 } 1576 }
1577 LMathMinMax* minmax = new(zone()) LMathMinMax(left, right); 1577 LMathMinMax* minmax = new(zone()) LMathMinMax(left, right);
(...skipping 985 matching lines...) Expand 10 before | Expand all | Expand 10 after
2563 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2563 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2564 LOperand* object = UseRegister(instr->object()); 2564 LOperand* object = UseRegister(instr->object());
2565 LOperand* index = UseTempRegister(instr->index()); 2565 LOperand* index = UseTempRegister(instr->index());
2566 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index)); 2566 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index));
2567 } 2567 }
2568 2568
2569 2569
2570 } } // namespace v8::internal 2570 } } // namespace v8::internal
2571 2571
2572 #endif // V8_TARGET_ARCH_X64 2572 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/x64/lithium-codegen-x64.cc ('k') | test/mjsunit/math-min-max.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698