Issue 20598007: NSS: rename ALPN extension to have _xtn suffix.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 20598007: NSS: rename ALPN extension to have _xtn suffix. (Closed)

Created:
7 years, 4 months ago by agl

Modified:
7 years, 4 months ago

Reviewers:
wtc

CC:
chromium-reviews, cbentzel+watch_chromium.org, Ryan Sleevi

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -22 lines)			Patch
M	net/socket/ssl_client_socket_nss.cc	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	net/third_party/nss/patches/alpn.patch	View		6 chunks	+6 lines, -6 lines	0 comments	Download
M	net/third_party/nss/ssl/ssl3ext.c	View		5 chunks	+13 lines, -13 lines	0 comments	Download
M	net/third_party/nss/ssl/sslt.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (0 generated)

wtc

Patch set 1 LGTM. Note that my CL https://codereview.chromium.org/20799005/ references the old ALPN extension enum ...

7 years, 4 months ago (2013-08-01 22:31:10 UTC) #2

wtc

agl: my CL https://codereview.chromium.org/20799005/ has landed. Could you also change my code to check for ...

7 years, 4 months ago (2013-08-02 15:10:47 UTC) #3

agl

Committed patchset #2 manually as r215290 (presubmit successful).

7 years, 4 months ago (2013-08-02 15:35:38 UTC) #4

Message was sent while issue was closed.

Done.