Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 20593003: Move kEnableExperimentalExtensionApis switch to extensions/common/switches.cc. (Closed)

Created:
7 years, 5 months ago by Yoyo Zhou
Modified:
7 years, 4 months ago
Reviewers:
Matt Perry, sky
CC:
chromium-reviews, vandebo (ex-Chrome), sadrul, yoshiki+watch_chromium.org, dmazzoni+watch_chromium.org, aandrey+blink_chromium.org, extensions-reviews_chromium.org, vsevik, ben+watch_chromium.org, aboxhall+watch_chromium.org, devtools-reviews_chromium.org, chromium-apps-reviews_chromium.org, dtseng+watch_chromium.org, yuzo+watch_chromium.org, paulirish+reviews_chromium.org, ctguil+watch_chromium.org, zork+watch_chromium.org, hashimoto+watch_chromium.org, Lei Zhang, tfarina, yurys, davidbarr+watch_chromium.org, tommycli, Greg Billock, pfeldman
Visibility:
Public.

Description

Move kEnableExperimentalExtensionApis switch to extensions/common/switches.cc. Remove it from a lot of API tests that don't need it anymore. BUG=162530 TBR=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=214836

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -144 lines) Patch
M chrome/browser/about_flags.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/accessibility/accessibility_extension_apitest.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 2 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/devtools/devtools_sanity_browsertest.cc View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/app_current_window_internal/app_current_window_internal_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/app_window/app_window_api.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/bluetooth/bluetooth_apitest.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_apitest.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/extensions/api/content_settings/content_settings_apitest.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/declarative/declarative_apitest.cc View 2 chunks +0 lines, -9 lines 0 comments Download
M chrome/browser/extensions/api/dns/dns_apitest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/history/history_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/idltest/idltest_apitest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/media_galleries/media_galleries_apitest.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/notifications/notifications_apitest.cc View 1 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/permissions/permissions_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/processes/processes_apitest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/socket/socket_apitest.cc View 2 chunks +0 lines, -9 lines 0 comments Download
M chrome/browser/extensions/api/system_storage/system_storage_apitest.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/system_storage/system_storage_eject_apitest.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/usb/usb_apitest.cc View 1 3 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/extensions/api/usb/usb_manual_apitest.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_apitest.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/extensions/crx_installer_browsertest.cc View 1 2 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_get_views_apitest.cc View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_keybinding_apitest.cc View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/extensions/extension_keybinding_apitest_new.cc View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/extensions/extension_toolbar_model_browsertest.cc View 3 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/extensions/isolated_app_browsertest.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/lazy_background_page_apitest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/platform_app_browsertest_util.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/process_management_browsertest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/window_open_apitest.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/infobars/infobar_extension_apitest.cc View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/rlz/rlz_extension_apitest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_app_browsertest.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/view_id_util_browsertest.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/extensions/extension.h View 2 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_background_unittest.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_experimental_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_isolatedapp_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/common/extensions/permissions/permissions_data.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/lazy_background_page/broadcast_event/manifest.json View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/lazy_background_page/browser_action_create_tab/manifest.json View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/lazy_background_page/browser_action_with_callback/manifest.json View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/lazy_background_page/filters/manifest.json View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/lazy_background_page/incognito_split/manifest.json View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/lazy_background_page/messaging/manifest.json View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/lazy_background_page/on_installed/manifest.json View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/lazy_background_page/on_unload/manifest.json View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/lazy_background_page/wait_for_ntp/manifest.json View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/lazy_background_page/wait_for_request/manifest.json View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/lazy_background_page/wait_for_view/manifest.json View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/notifications/galore/app/manifest.json View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/socket/unload/manifest.json View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/common/switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/common/switches.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
Yoyo Zhou
It's a lot of files but very little changes.
7 years, 5 months ago (2013-07-26 01:03:47 UTC) #1
Matt Perry
lgtm
7 years, 5 months ago (2013-07-26 01:12:19 UTC) #2
Yoyo Zhou
TBR=sky for trivial refactoring.
7 years, 5 months ago (2013-07-26 01:25:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoz@chromium.org/20593003/1
7 years, 5 months ago (2013-07-26 04:11:08 UTC) #4
commit-bot: I haz the power
Failed to apply patch for chrome/common/chrome_switches.h: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 5 months ago (2013-07-26 04:11:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoz@chromium.org/20593003/7001
7 years, 5 months ago (2013-07-26 18:43:23 UTC) #6
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=63848
7 years, 4 months ago (2013-07-27 23:51:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoz@chromium.org/20593003/7001
7 years, 4 months ago (2013-07-28 00:13:59 UTC) #8
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=63971
7 years, 4 months ago (2013-07-28 02:36:09 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoz@chromium.org/20593003/7001
7 years, 4 months ago (2013-07-28 09:45:18 UTC) #10
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=64099
7 years, 4 months ago (2013-07-28 11:40:41 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoz@chromium.org/20593003/7001
7 years, 4 months ago (2013-07-30 08:16:42 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoz@chromium.org/20593003/7001
7 years, 4 months ago (2013-07-30 15:00:59 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoz@chromium.org/20593003/7001
7 years, 4 months ago (2013-07-30 20:50:37 UTC) #14
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests, content_browsertests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=65388
7 years, 4 months ago (2013-07-31 03:28:58 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoz@chromium.org/20593003/67001
7 years, 4 months ago (2013-07-31 18:11:06 UTC) #16
commit-bot: I haz the power
7 years, 4 months ago (2013-07-31 22:16:58 UTC) #17
Message was sent while issue was closed. 
Change committed as 214836

Powered by Google App Engine
This is Rietveld 408576698