Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(590)

Side by Side Diff: chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_apitest.cc

Issue 20593003: Move kEnableExperimentalExtensionApis switch to extensions/common/switches.cc. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/command_line.h" 5 #include "base/command_line.h"
6 #include "base/prefs/pref_service.h" 6 #include "base/prefs/pref_service.h"
7 #include "base/strings/utf_string_conversions.h" 7 #include "base/strings/utf_string_conversions.h"
8 #include "chrome/browser/bookmarks/bookmark_model.h" 8 #include "chrome/browser/bookmarks/bookmark_model.h"
9 #include "chrome/browser/bookmarks/bookmark_model_factory.h" 9 #include "chrome/browser/bookmarks/bookmark_model_factory.h"
10 #include "chrome/browser/extensions/api/bookmark_manager_private/bookmark_manage r_private_api.h" 10 #include "chrome/browser/extensions/api/bookmark_manager_private/bookmark_manage r_private_api.h"
11 #include "chrome/browser/extensions/extension_apitest.h" 11 #include "chrome/browser/extensions/extension_apitest.h"
12 #include "chrome/browser/profiles/profile.h" 12 #include "chrome/browser/profiles/profile.h"
13 #include "chrome/browser/ui/browser.h" 13 #include "chrome/browser/ui/browser.h"
14 #include "chrome/common/chrome_switches.h"
15 #include "chrome/common/pref_names.h" 14 #include "chrome/common/pref_names.h"
16 #include "chrome/test/base/ui_test_utils.h" 15 #include "chrome/test/base/ui_test_utils.h"
17 #include "components/user_prefs/user_prefs.h" 16 #include "components/user_prefs/user_prefs.h"
18 17
19 // Times out on win asan, http://crbug.com/166026 18 // Times out on win asan, http://crbug.com/166026
20 #if defined(OS_WIN) && defined(ADDRESS_SANITIZER) 19 #if defined(OS_WIN) && defined(ADDRESS_SANITIZER)
21 #define MAYBE_BookmarkManager DISABLED_BookmarkManager 20 #define MAYBE_BookmarkManager DISABLED_BookmarkManager
22 #else 21 #else
23 #define MAYBE_BookmarkManager BookmarkManager 22 #define MAYBE_BookmarkManager BookmarkManager
24 #endif 23 #endif
25 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, MAYBE_BookmarkManager) { 24 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, MAYBE_BookmarkManager) {
26 CommandLine::ForCurrentProcess()->AppendSwitch(
27 switches::kEnableExperimentalExtensionApis);
28
29 ASSERT_TRUE(RunComponentExtensionTest("bookmark_manager/standard")) 25 ASSERT_TRUE(RunComponentExtensionTest("bookmark_manager/standard"))
30 << message_; 26 << message_;
31 } 27 }
32 28
33 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, BookmarkManagerEditDisabled) { 29 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, BookmarkManagerEditDisabled) {
34 CommandLine::ForCurrentProcess()->AppendSwitch(
35 switches::kEnableExperimentalExtensionApis);
36
37 Profile* profile = browser()->profile(); 30 Profile* profile = browser()->profile();
38 31
39 // Provide some testing data here, since bookmark editing will be disabled 32 // Provide some testing data here, since bookmark editing will be disabled
40 // within the extension. 33 // within the extension.
41 BookmarkModel* model = BookmarkModelFactory::GetForProfile(profile); 34 BookmarkModel* model = BookmarkModelFactory::GetForProfile(profile);
42 ui_test_utils::WaitForBookmarkModelToLoad(model); 35 ui_test_utils::WaitForBookmarkModelToLoad(model);
43 const BookmarkNode* bar = model->bookmark_bar_node(); 36 const BookmarkNode* bar = model->bookmark_bar_node();
44 const BookmarkNode* folder = model->AddFolder(bar, 0, ASCIIToUTF16("Folder")); 37 const BookmarkNode* folder = model->AddFolder(bar, 0, ASCIIToUTF16("Folder"));
45 model->AddURL(bar, 1, ASCIIToUTF16("AAA"), GURL("http://aaa.example.com")); 38 model->AddURL(bar, 1, ASCIIToUTF16("AAA"), GURL("http://aaa.example.com"));
46 model->AddURL(folder, 0, ASCIIToUTF16("BBB"), GURL("http://bbb.example.com")); 39 model->AddURL(folder, 0, ASCIIToUTF16("BBB"), GURL("http://bbb.example.com"));
47 40
48 PrefService* prefs = user_prefs::UserPrefs::Get(profile); 41 PrefService* prefs = user_prefs::UserPrefs::Get(profile);
49 prefs->SetBoolean(prefs::kEditBookmarksEnabled, false); 42 prefs->SetBoolean(prefs::kEditBookmarksEnabled, false);
50 43
51 ASSERT_TRUE(RunComponentExtensionTest("bookmark_manager/edit_disabled")) 44 ASSERT_TRUE(RunComponentExtensionTest("bookmark_manager/edit_disabled"))
52 << message_; 45 << message_;
53 } 46 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698