service/datastore/pls_test.go - Issue 2048933004: Refactor multiarg, split MGS/PLS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: service/datastore/pls_test.go

Issue 2048933004: Refactor multiarg, split MGS/PLS. (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/gae@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: service/datastore/pls_test.go

diff --git a/service/datastore/pls_test.go b/service/datastore/pls_test.go

index c997765ff5c96a58ff26f6f0fb8a1de304c6e348..3fdcf8a923af4c21ad89203f6bfacba717a6b8b2 100644

--- a/service/datastore/pls_test.go

+++ b/service/datastore/pls_test.go

@@ -1814,7 +1814,7 @@ func TestMeta(t *testing.T) {

Convey("attempting to get a PLS for a non *struct is an error", func() {

So(func() { GetPLS((*[]string)(nil)) }, ShouldPanicLike,

- "cannot GetPLS(*[]string): not a pointer-to-struct")

+ "cannot GetPLS(*[]string): pointer-to-struct is nil")

iannucci 2016/06/14 00:19:51 hm, I think the spirit of this test was lost?

dnj (Google) 2016/06/14 01:49:43 Hah true that. Added separate tests for "not a poi

})

Convey("convertible meta default types", func() {