Refactor multiarg, split MGS/PLS.

service/datastore/pls_test.go

 // Copyright 2015 The LUCI Authors. All rights reserved.
 // Use of this source code is governed under the Apache License, Version 2.0
 // that can be found in the LICENSE file.
 
 // adapted from github.com/golang/appengine/datastore
 
 package datastore
 
 import (
         "bytes"
@@ skipping 1796 matching lines @@
                         o := &BadMeta{}
                         So(func() { GetPLS(o) }, ShouldPanicLike, "multiple times")
                 })
 
                 Convey("empty property names are invalid", func() {
                         So(validPropertyName(""), ShouldBeFalse)
                 })
 
                 Convey("attempting to get a PLS for a non *struct is an error", func() {
                         So(func() { GetPLS((*[]string)(nil)) }, ShouldPanicLike,
-                                "cannot GetPLS(*[]string): not a pointer-to-struct")
+                                "cannot GetPLS(*[]string): pointer-to-struct is nil")

[iannucci, 2016/06/14 00:19:51]

hm, I think the spirit of this test was lost?

[dnj (Google), 2016/06/14 01:49:43]

Hah true that. Added separate tests for "not a pointer-to-struct" and "pointer
is nil".

                 })
 
                 Convey("convertible meta default types", func() {
                         type OKDefaults struct {
                                 When   string `gae:"$when,tomorrow"`
                                 Amount int64  `gae:"$amt,100"`
                                 DoIt   Toggle `gae:"$doit,on"`
                         }
                         okd := &OKDefaults{}
                         mgs := getMGS(okd)
@@ skipping 195 matching lines @@
                         So(pls.SetMeta("id", "sup|1337"), ShouldBeTrue)
                         So(ide.EmbeddedID, ShouldResemble, EmbeddedID{"sup", 1337})
 
                         So(pls.GetAllMeta(), ShouldResemble, PropertyMap{
                                 "$id":   {mpNI("sup|1337")},
                                 "$kind": {mpNI("IDEmbedder")},
                         })
                 })
         })
 }