Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Unified Diff: service/datastore/interface.go

Issue 2048933004: Refactor multiarg, split MGS/PLS. (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/gae@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: service/datastore/interface.go
diff --git a/service/datastore/interface.go b/service/datastore/interface.go
index 9560108ed2ae09404a5dc6fe104fb7c07573b6c1..b1d022b4e359f07043153225bcb58250fa3c169b 100644
--- a/service/datastore/interface.go
+++ b/service/datastore/interface.go
@@ -137,8 +137,8 @@ type Interface interface {
// Exists tests if the supplied objects are present in the datastore.
//
// ent must be one of:
- // - *S where S is a struct
- // - *P where *P is a concrete type implementing PropertyLoadSaver
+ // - *S, where S is a struct
+ // - *P, where *P is a concrete type implementing PropertyLoadSaver
// - []S or []*S where S is a struct
// - []P or []*P where *P is a concrete type implementing PropertyLoadSaver
// - []I where i is some interface type. Each element of the slice must
@@ -209,6 +209,7 @@ type Interface interface {
// src must be one of:
// - *S where S is a struct
// - *P where *P is a concrete type implementing PropertyLoadSaver
+ // IDs will NOT be written back.
iannucci 2016/06/14 00:19:51 whoa why? Even if it implements MetaGetterSetter?
dnj (Google) 2016/06/14 01:49:43 oops, that's leftover from when they were structs.
// - []S or []*S where S is a struct
// - []P or []*P where *P is a concrete type implementing PropertyLoadSaver
// - []I where i is some interface type. Each element of the slice must
iannucci 2016/06/14 00:19:51 and everywhere
dnj (Google) 2016/06/14 01:49:43 Done.
@@ -248,8 +249,8 @@ type Interface interface {
// Delete removes the supplied entities from the datastore.
//
// ent must be one of:
- // - *S where S is a struct
- // - *P where *P is a concrete type implementing PropertyLoadSaver
+ // - *S, where S is a struct
+ // - *P, where *P is a concrete type implementing PropertyLoadSaver
// - []S or []*S where S is a struct
// - []P or []*P where *P is a concrete type implementing PropertyLoadSaver
// - []I where i is some interface type. Each element of the slice must

Powered by Google App Engine
This is Rietveld 408576698