Implement ClassMirror.superclass with internal code for ordinary (but not function type) classes. R…

Implement ClassMirror.superclass with internal code for ordinary (but not function type) classes. Resolves issue 5794 and issue 9434.

R=asiva@google.com

Committed: https://code.google.com/p/dart/source/detail?r=25508

[rmacnak, 2013-07-25 20:51:51]

https://chromiumcodereview.appspot.com/20465002/diff/1/runtime/lib/mirrors.cc
File runtime/lib/mirrors.cc (right):

https://chromiumcodereview.appspot.com/20465002/diff/1/runtime/lib/mirrors.cc...
runtime/lib/mirrors.cc:1055: DEFINE_NATIVE_ENTRY(ClassMirror_supertype, 1) {
We answer a Type instead of a ClassMirror for two reasons:

1) We can hit the cache on reflectClass()

2) We will eventually need to change the reflectee of a ClassMirror from a
RawClass to a RawAbstractType, because a RawClass doesn't have the type
arguments we will need to implement ClassMirror.typeArguments.

[siva, 2013-07-25 21:54:12]

lgtm

https://codereview.chromium.org/20465002/diff/1/runtime/lib/mirrors_impl.dart
File runtime/lib/mirrors_impl.dart (right):

https://codereview.chromium.org/20465002/diff/1/runtime/lib/mirrors_impl.dart...
runtime/lib/mirrors_impl.dart:454: Type supertype = _supertype(_reflectee);
var supertype?

[rmacnak, 2013-07-25 22:32:55]

On 2013/07/25 21:54:12, siva wrote:
> lgtm
> 
> https://codereview.chromium.org/20465002/diff/1/runtime/lib/mirrors_impl.dart
> File runtime/lib/mirrors_impl.dart (right):
> 
>
https://codereview.chromium.org/20465002/diff/1/runtime/lib/mirrors_impl.dart...
> runtime/lib/mirrors_impl.dart:454: Type supertype = _supertype(_reflectee);
> var supertype?

It should be a Type or null. I want the checked-mode test.

[rmacnak, 2013-07-25 22:45:11]

Committed patchset #2 manually as r25508 (presubmit successful).