Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 20420002: Make Wallet respect whether or not shipping address is required. (Closed)

Created:
7 years, 5 months ago by ahutter
Modified:
7 years, 4 months ago
Reviewers:
Ilya Sherman, Dan Beam
CC:
chromium-reviews, Raman Kakilate, benquan, jam, ahutter, browser-components-watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Albert Bodenhamer, Ilya Sherman, rouslan+autofillwatch_chromium.org
Visibility:
Public.

Description

Make Wallet respect whether or not shipping address is required. BUG=245794 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=214576

Patch Set 1 #

Total comments: 2

Patch Set 2 : Removing unused functions #

Total comments: 5

Patch Set 3 : Wallet client respects delegates shipping preference. #

Messages

Total messages: 12 (0 generated)
ahutter
Dan, PTAL. Thanks!
7 years, 5 months ago (2013-07-25 18:51:07 UTC) #1
Dan Beam
https://codereview.chromium.org/20420002/diff/1/components/autofill/content/browser/wallet/wallet_client_delegate.h File components/autofill/content/browser/wallet/wallet_client_delegate.h (right): https://codereview.chromium.org/20420002/diff/1/components/autofill/content/browser/wallet/wallet_client_delegate.h#newcode53 components/autofill/content/browser/wallet/wallet_client_delegate.h:53: virtual bool IsPhoneNumberRequired() const = 0; ^ are there ...
7 years, 5 months ago (2013-07-25 19:37:02 UTC) #2
ahutter
https://codereview.chromium.org/20420002/diff/1/components/autofill/content/browser/wallet/wallet_client_delegate.h File components/autofill/content/browser/wallet/wallet_client_delegate.h (right): https://codereview.chromium.org/20420002/diff/1/components/autofill/content/browser/wallet/wallet_client_delegate.h#newcode53 components/autofill/content/browser/wallet/wallet_client_delegate.h:53: virtual bool IsPhoneNumberRequired() const = 0; On 2013/07/25 19:37:03, ...
7 years, 5 months ago (2013-07-26 16:03:35 UTC) #3
Dan Beam
lgtm https://codereview.chromium.org/20420002/diff/5001/components/autofill/content/browser/wallet/wallet_client.cc File components/autofill/content/browser/wallet/wallet_client.cc (right): https://codereview.chromium.org/20420002/diff/5001/components/autofill/content/browser/wallet/wallet_client.cc#newcode342 components/autofill/content/browser/wallet/wallet_client.cc:342: request_dict.SetBoolean(kPhoneNumberRequired, true); ^ if we don't need to ...
7 years, 5 months ago (2013-07-26 17:54:31 UTC) #4
ahutter
https://codereview.chromium.org/20420002/diff/5001/components/autofill/content/browser/wallet/wallet_client.cc File components/autofill/content/browser/wallet/wallet_client.cc (right): https://codereview.chromium.org/20420002/diff/5001/components/autofill/content/browser/wallet/wallet_client.cc#newcode342 components/autofill/content/browser/wallet/wallet_client.cc:342: request_dict.SetBoolean(kPhoneNumberRequired, true); On 2013/07/26 17:54:31, Dan Beam wrote: > ...
7 years, 5 months ago (2013-07-26 18:21:23 UTC) #5
ahutter
Ilya, PTAL at autocheckout_request_manager.*. Thanks!
7 years, 5 months ago (2013-07-26 18:22:01 UTC) #6
Dan Beam
https://codereview.chromium.org/20420002/diff/5001/components/autofill/content/browser/wallet/wallet_client.cc File components/autofill/content/browser/wallet/wallet_client.cc (right): https://codereview.chromium.org/20420002/diff/5001/components/autofill/content/browser/wallet/wallet_client.cc#newcode342 components/autofill/content/browser/wallet/wallet_client.cc:342: request_dict.SetBoolean(kPhoneNumberRequired, true); On 2013/07/26 18:21:28, ahutter wrote: > On ...
7 years, 5 months ago (2013-07-26 18:24:48 UTC) #7
Ilya Sherman
LGTM
7 years, 5 months ago (2013-07-26 21:45:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ahutter@chromium.org/20420002/11001
7 years, 4 months ago (2013-07-29 18:11:45 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ahutter@chromium.org/20420002/11001
7 years, 4 months ago (2013-07-30 02:46:29 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ahutter@chromium.org/20420002/11001
7 years, 4 months ago (2013-07-30 13:56:55 UTC) #11
commit-bot: I haz the power
7 years, 4 months ago (2013-07-31 05:30:24 UTC) #12
Message was sent while issue was closed. 
Change committed as 214576

Powered by Google App Engine
This is Rietveld 408576698