Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 203743003: Trigger extra GraphicsLayerGeometryUpdate for squashing if we reset compositedBounds on squashed la… (Closed)

Created:
6 years, 9 months ago by hartmanng
Modified:
6 years, 9 months ago
Reviewers:
Ian Vollick, chrishtr
CC:
blink-reviews, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, abarth-chromium, jchaffraix+rendering, pdr.
Visibility:
Public.

Description

Trigger extra GraphicsLayerGeometryUpdate for squashing if we reset compositedBounds on squashed layers. Currently we're skipping a necessary update case in squashed layers due to an early-out in CompositedLayerMapping::updateGraphicsLayerGeometry() because m_needToUpdateGeometry is false. This explicitly sets m_needToUpdateGeometry to true when we reset the squashed layers' compositedBounds so that they're correctly recomputed before trying to paint. BUG=349308

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M Source/core/rendering/compositing/CompositedLayerMapping.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
hartmanng
Ian, please take a look. The fix is trivial, but I'm still working on a ...
6 years, 9 months ago (2014-03-18 18:58:46 UTC) #1
Ian Vollick
On 2014/03/18 18:58:46, hartmanng wrote: > Ian, please take a look. The fix is trivial, ...
6 years, 9 months ago (2014-03-18 23:48:57 UTC) #2
chrishtr
6 years, 9 months ago (2014-03-19 21:51:41 UTC) #3

Powered by Google App Engine
This is Rietveld 408576698